Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Fix initial depth copy w/o existing depth #16200

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

unknownbrackets
Copy link
Collaborator

Saw this crash when running the frame dump from #6979. Blit already had it, just not copy.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.14.0 milestone Oct 11, 2022
@hrydgard
Copy link
Owner

Oops!

@hrydgard hrydgard merged commit 8b2e7d6 into hrydgard:master Oct 11, 2022
@unknownbrackets unknownbrackets deleted the vulkan-depth branch October 11, 2022 05:44
@hrydgard
Copy link
Owner

I realized there are a few similar cases such as when we use raster to copy depth when resizing framebuffers. That one will take a bit more plumbing to fix, so I'm gonna revert the on-demand depth buffer creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants