GLES: Avoid resizing tessellation data textures #16078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just recreate when it needs to be larger. Fixes Test Drive Unlimited issues noted in hrydgard#16069.
|
Yeah, this is the way to go, nice find. I really dislike these textures in general though, but since vertex shader storage buffer access is not available in GLES, we don't have much choice, unless we rip out hw tessellation in GLES. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just recreate when it needs to be larger. Fixes Test Drive Unlimited issues noted in #16069.
In theory, these were all init steps, and since size_u and size_v could vary, at least that part was wrong. That said, I think it's better to just create a new texture each time. When stepping in the GE debugger, it drew correctly, only because each one flushed.
-[Unknown]