GPU: Clip clamped depth accounting for perspective #16068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome! yes, things in these perspective spaces are rarely intuitive... |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking about it, it'd need to account for w in order to properly clip, so this makes sense. It was not at all obvious from the GL or Vulkan clip distance documentation.
The range cull is already based on w (it's z < -w after all), so I think it needs no change. In theory, cull distance shouldn't need to care about w, since it's just if all verts are below zero.
This fixes the Toca frame dump without breaking the Pursuit Force frame dump.
-[Unknown]