Config: Don't save --fullscreen unless changed #15558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes --fullscreen and --windowed temporary by using a separate setting. If the setting is changed explicitly, it begins saving it again.
|
Works perfectly! Thank you so much! |
|
Nice and straightforward, thanks! Feels like something a future configuration system could support in a more generic way, although of course would need to do everything through accessors, which isn't always super attractive. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes --fullscreen and --windowed temporary by using a separate setting. If the setting is changed explicitly, it begins saving it again. This seemed like the simplest way - don't change the setting, actually.
Note that the full screen checkbox will be unchecked in settings (even while full screen) in this state. It could show checked instead, but I felt like it was clearer for this to reflect the setting rather than the current state. Could be convinced otherwise, though.
Fixes #15557.
-[Unknown]