Compat: Ignore DisableRangeCulling with clip/cull #15035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
reviewed
Oct 21, 2021
GPU/D3D11/GPU_D3D11.cpp
Outdated
Comment on lines
133
to
138
| // Ignore the compat setting if clip and cull are both enabled. | ||
| const bool supported = draw_->GetDeviceCaps().clipDistanceSupported && draw_->GetDeviceCaps().cullDistanceSupported; | ||
| const bool disabled = PSP_CoreParameter().compat.flags().DisableRangeCulling; | ||
| if (supported && !disabled) { | ||
| features |= GPU_SUPPORTS_VS_RANGE_CULLING; | ||
| } |
There was a problem hiding this comment.
Hm. Am I reading this right? So if clip/cull are supported, we still use old school VS range culling?
I would have thought the logic should be
if (!supported && !disabled) {
There was a problem hiding this comment.
Oops, yes. Don't remember if I just forgot to flip after testing or made a dumb typo.
-[Unknown]
There was a problem hiding this comment.
Oh wait, no. We want range culling still. Range culling still happens.
-[Unknown]
As long as we support these things and the NAN issue isn't there, we should be able to safely enable regardless.
unknownbrackets
force-pushed
the
guardband
branch
from
1f1c501 to
c72d045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as we support these things and the NAN issue isn't there, we should be able to safely enable regardless. Related to #14833.
This may improve graphics in games where the feature was forced off (correctly culling what should be culled), but shouldn't affect the devices which don't yet support clip and cull.
-[Unknown]