GPU: Blit framebuf depth on create too #15027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't change anything yet, just moving logic around.
Before we only did it for an existing target framebuffer, and never for a fresh one. But there's not really a good reason to skip that, and this may improve effects that are cemented after a single frame.
|
This seems good. However in #7810 it sounds like in that case, it papers over another bug with how we recognize depth buffers, possibly? Weird. Still of course, this should go in, and will once the 12.3 release is out. |
|
Well, you could say copying depth always papers over the bug where we don't share depth? What I don't know is if this is the cause of the runtime flickering. But the depth it establishes on the prev framebuffer needs to be there for it to properly render the shadows on the temp framebuffer which uses the same z_address. This isn't papering over that to any greater extent than the normal depth blitting is. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7810. This is a potential cause of shadow flickering, and skipping could cause other issues. I think it makes sense to blit just like we do on switch.
-[Unknown]