Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple key for single button #14793

Closed
wants to merge 1 commit into from
Closed

Multiple key for single button #14793

wants to merge 1 commit into from

Conversation

iota97
Copy link
Contributor

@iota97 iota97 commented Sep 5, 2021

Allows to bind 2 button combination.

1
2
0

@hrydgard
Copy link
Owner

hrydgard commented Sep 5, 2021

I like the feature, but asking for one or two buttons gets really confusing for new users I would think, and the messages will flicker by quickly for normal bindings. I've never seen a binding interface like this before.

I need to think about if I want this in for 1.12, and how we'll solve the UX issue. But maybe it can be a hidden feature for a while?

@hrydgard
Copy link
Owner

Could you rebase this? I'd like to experiment with this again.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Jan 12, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Jan 12, 2023
@iota97
Copy link
Contributor Author

iota97 commented Jan 12, 2023

Rebase had quite some conflict (more "hidden" than not). Seems fine from quick test but I have no controller or multiple device to more complex test.

No UI because it changed in the meanwhile and I don't really have the time to understand what happened (also we was not sure how to do it anyway). This mean u have to press to button at binding time to create the combo, but it's kinda hidden feature :)

@hrydgard
Copy link
Owner

hrydgard commented Jan 12, 2023

It might be okay to be a hidden feature, as long as it's obvious afterwards what you did :)

I'll play with it soon and see what UI changes might be necessary, if any.

@hrydgard
Copy link
Owner

Sorry for taking so long with this, but I have finally played with it a bit more and I want it in as is :)

Wanna rebase it or should I? Sorry again for the need for another rebase...

@iota97
Copy link
Contributor Author

iota97 commented Mar 22, 2023

I don't have access to a PC with a compiler/PPSSPP source code untill next month.

The conflict seems easy enough but tried the Web conflict fix once and it messed with indentation so I don't trust it anymore :P

It's probably the best if you could it if you don't wanna wait :)

@hrydgard
Copy link
Owner

Alright, I'll do it pretty soon then :)

@hrydgard
Copy link
Owner

Closing in favor of #17168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants