-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple key for single button #14793
Conversation
I like the feature, but asking for one or two buttons gets really confusing for new users I would think, and the messages will flicker by quickly for normal bindings. I've never seen a binding interface like this before. I need to think about if I want this in for 1.12, and how we'll solve the UX issue. But maybe it can be a hidden feature for a while? |
Could you rebase this? I'd like to experiment with this again. |
Rebase had quite some conflict (more "hidden" than not). Seems fine from quick test but I have no controller or multiple device to more complex test. No UI because it changed in the meanwhile and I don't really have the time to understand what happened (also we was not sure how to do it anyway). This mean u have to press to button at binding time to create the combo, but it's kinda hidden feature :) |
It might be okay to be a hidden feature, as long as it's obvious afterwards what you did :) I'll play with it soon and see what UI changes might be necessary, if any. |
Sorry for taking so long with this, but I have finally played with it a bit more and I want it in as is :) Wanna rebase it or should I? Sorry again for the need for another rebase... |
I don't have access to a PC with a compiler/PPSSPP source code untill next month. The conflict seems easy enough but tried the Web conflict fix once and it messed with indentation so I don't trust it anymore :P It's probably the best if you could it if you don't wanna wait :) |
Alright, I'll do it pretty soon then :) |
Closing in favor of #17168. |
Allows to bind 2 button combination.