Allow PNGs and http:// for headless test expected files #13939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes not just graphics-enabled tests work in headless on softgpu, but also screenshot comparison ones.
This makes it possible to run tests from network locations.
|
This is great! A .ppdmp / png test suite will be fantastic to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few related changes:
.expectedand.expected.bmpfiles to be read via http:// for prx tests..ppdmpfiles to be run in one shot via headless and output a screenshot for compare.--compareuse PNGs by default for ppdmps since it's more convenient there.This is in some ways related to #11888. However, at this point it just makes headless able to run
.ppdmptests via CI or command line effectively, which I see as a prerequisite to even maintaining tests for mobile devices/etc.-[Unknown]