GPU: Correct shader gen with weights as floats #13906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, this supports the option. We should probably just move to everything being floats, but we already prefer software skinning. Fixes hrydgard#13903.
unknownbrackets
changed the title
|
Oh good catch! Not sure how I missed this during the big shader unification... Yeah, you're right that supporting smaller formats for weights is probably not worth the trouble really.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this supports the option. We should probably just move to everything being floats, but we already prefer software skinning.
Fixes #13903.
Although another parameter is slightly annoying, I figured this was the safest fix for any upcoming release. I know software skinning is slower in some uncommon cases, but before we force to floats/etc. we should probably consider whether we keep the option or if switching to floats is part of that equation in some unlikely way.
-[Unknown]