Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaderblend code cleanup #13637

Merged
merged 6 commits into from
Nov 8, 2020
Merged

Shaderblend code cleanup #13637

merged 6 commits into from
Nov 8, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 8, 2020

Shader blend is really two separate concepts that have gotten intermingled in the code:

  • Read from framebuffer in shader (copy or directly, depending on shader)
  • Actually do the blend equation inside the shader (sometimes necessary for PSP-specific weirdness)

The second requires the first, but the first could also be used for other things (color bitmasks, soon), so separate the naming and clean things up a bit.

Also deletes reporting code for weird color masks. We know what these are and how they work..

@hrydgard hrydgard added GE emulation Backend-independent GPU issues Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. labels Nov 8, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Nov 8, 2020
@hrydgard hrydgard merged commit 7632c12 into master Nov 8, 2020
@hrydgard hrydgard deleted the shaderblend-cleanup branch November 8, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant