Workaround for ULJS00218 until a more correct VFPU sin/cos implementation can be found. #13523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May not be related, just some possible condition on floating point: Btw, you guys aren't making use Epsilon for these |
…tion can be found. JIT only for now.
hrydgard
force-pushed
the
hitman-reborn-workaround
branch
from
64795e5 to
238149d
Compare
|
#13526 seems like a more promising direction, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #12900 for the broken game and rationale.
Basically we need a more accurate version of this function. This old one is probably actually slightly higher precision than what we're using now in other games.
JIT only for now.