Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer code cleanups, log changes, enable BlockTransferAllowCreateFB for Burnout Legends #13246

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 4, 2020

Changes to the logging. I'm now comfortable enabling BlockTransferAllowCreateFB for Burnout Legends, eliminating the slow readback. Thus, fixes #12345 .

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Aug 4, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Aug 4, 2020
@hrydgard hrydgard merged commit 9f147e8 into master Aug 4, 2020
@hrydgard hrydgard deleted the framebuffer-code-cleanups branch August 4, 2020 16:12
@ghost
Copy link

ghost commented Aug 5, 2020

Burnout Legends performance still the same :(
still lag @ 2X resolution with simulate block transfer effects enable.
Screenshot_2020-08-05-15-59-56

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 5, 2020

@Gamemulatorer can you check the game ID of your ISO? Maybe I missed one in the compat.ini setting.

@ghost
Copy link

ghost commented Aug 5, 2020

It's ULES00125 and its already added to compat.ini

@Panderner
Copy link
Contributor

I'm using Realme C2 and performance of this game running smoothly in 2x resolution on latest build:

We compared the Lastest build and older versions:
v1.10.3-319-g9f147e870 and newer:
Screenshot_2020-08-06-01-32-56-40_2f85358b2198d26f8aca533d68bee793
v1.10.3-315-gb5cc3a0ba and older:
Screenshot_2020-08-06-01-38-42-27_2f85358b2198d26f8aca533d68bee793

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 5, 2020

Yeah this should be a noticeable improvement on many devices, but some devices still might not have enough power to run this game at 2x, of course. Wouldn't expect much additional improvement from here unfortunately.

@ghost
Copy link

ghost commented Aug 5, 2020

Im using android lollipop with mali450 gpu octacore cpu
Here's my log hope it can help improve the performance of this game on my phone :)
ULES00125.zip

@ghost
Copy link

ghost commented Aug 7, 2020

This is ok now on my phone I just set the build prop "viewroot.profile_rendering=false"

Set this system property to true to force the view hierarchy to render at 60 Hz. This can be used to measure the potential framerate.

Why is ppsspp lag when is set it to true? other emulator like mame4droid, epsxe and reicast still running smooth when this prop is set to true.

Screenshot of the game running 27/30fps @ 2x resolution with simulate block transfer effects enable
Screenshot_2020-08-07-08-06-32
But still got a framedrops when too many opponents or during crashing the cars 😅

@Panderner
Copy link
Contributor

This is ok now on my phone I just set the build prop "viewroot.profile_rendering=false"

Set this system property to true to force the view hierarchy to render at 60 Hz. This can be used to measure the potential framerate.

Why is ppsspp lag when is set it to true? other emulator like mame4droid, epsxe and reicast still running smooth when this prop is set to true.

Screenshot of the game running 27/30fps @ 2x resolution
Screenshot_2020-08-07-08-06-32
But still got a framedrops when too may opponents

Maybe your phone refresh rate issue. any android displays below 60hz might be unsuitable for all NTSC console games even Game Boy and NES Emulators

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 7, 2020

@Gamemulatorer If viewroot.profile_rendering=false makes a difference, you should go into developer settings on your phone and turn off GPU profiling. Having it enabled is probably losing you a lot of performance across many games.

@ghost
Copy link

ghost commented Aug 7, 2020

@hrydgard there's a possibility that will you add soon Naruto Shippuden Ultimate Ninja Impact to BlockTransferAllowCreateFB compat.ini?

@ghost
Copy link

ghost commented Aug 25, 2020

burnout legends sun black box issue is not fixed on old adreno gpu see #13332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burnout Legends: Find a way to enable BlockTransferAllowCreateFB cleanly
2 participants