Vulkan: Some surface code cleanup #13164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -350,13 +350,14 @@ void GameSettingsScreen::CreateViews() { | |||
| } | |||
| #endif | |||
|
|
|||
| #ifdef _WIN32 | |||
| #if !PPSSPP_PLATFORM(ANDROID) | |||
There was a problem hiding this comment.
It's Vulkan only though, right? Worried this may cause confusion for people on OpenGL, i.e. Raspberry pi, etc.
-[Unknown]
There was a problem hiding this comment.
Fully aware of this - which I will fix in a followup by simply adding support for toggling VSync on these platforms too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #13041 . Did it somewhat differently, now works flawlessly on Linux for some reason, even when not recreating the surface on resize. Doesn't yet use oldSwapchain though, which will be required for switching vsync mode without stalling the GPU in the future.
Also enables the VSync setting on more platforms. There's more work to be done there though.
Shortens some logging, too.
The end goal of this stuff is better control over the swapchain, including seamless switches between vsync and not, for better unthrottle when vsynced, this is just a step on the way there though.
Also (accidentally, but decided to go with it) includes the fix for the issue @Anuskuss found with Vulkan and vsync and unthrottling.