Display: Allow unthrottle to skip only flipping #12970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay, I've wanted this for a long time. On the fence whether to merge it for 1.10... |
This was referenced May 25, 2020
|
Gonna need a little rebase here, sorry :) |
Before, it either flipped continuously, or forced frameskip on. This makes it so you can still draw frames, but skip actual flips. This is useful when games draw things only in a single frame and reuse later. It's also useful when measuring speed improvements if you already get 100% speed on a device.
Three spaces is weird, but better to be consistent and have the config specify what's being used.
unknownbrackets
force-pushed
the
unthrottle
branch
from
e062a12 to
50060c9
Compare
|
There was another conflict (caused by my latest changes) so I merged locally. Closing. |
|
We may even want to consider exposing this in the UI or making it default to SKIP_FLIP when frameskip is otherwise off. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it either flipped continuously, or forced frameskip on. This makes it so you can still draw frames, but skip actual flips.
This is useful when games draw things only in a single frame and reuse later. It's also useful when measuring speed improvements if you already get 100% speed on a device.
This resets the previous FrameskipUnthrottle setting. That said, this may be a good thing because some users changed it when vsync/postshaders were not interacting as well with it, and I think those problems are fixed.
-[Unknown]