Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Notch support #12782

Merged
merged 1 commit into from
Apr 1, 2020
Merged

[iOS] Notch support #12782

merged 1 commit into from
Apr 1, 2020

Conversation

Florin9doi
Copy link
Contributor

@Florin9doi Florin9doi commented Mar 31, 2020

I tested this only on simulator.

Before:
Screenshot 2020-03-31 at 19 14 02

How it would look if we consider the bottom area too:
Screenshot 2020-03-31 at 19 16 02

This commit; the bottom area is unchanged:
Screenshot 2020-03-31 at 19 22 59

ios/main.mm Outdated
@@ -73,6 +78,14 @@ float System_GetPropertyFloat(SystemProperty prop) {
switch (prop) {
case SYSPROP_DISPLAY_REFRESH_RATE:
return 60.f;
case SYSPROP_DISPLAY_SAFE_INSET_LEFT:
Copy link
Owner

@hrydgard hrydgard Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation inconsistent here. also below

@hrydgard
Copy link
Owner

Looks good, fix the tabs and I'll merge :)

@@ -148,6 +148,16 @@ - (void)subtleVolume:(SubtleVolume *)volumeView willChange:(CGFloat)value {
- (void)subtleVolume:(SubtleVolume *)volumeView didChange:(CGFloat)value {
}

- (void)viewSafeAreaInsetsDidChange {
[super viewSafeAreaInsetsDidChange];
if (@available(iOS 11.0, *)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs xcode 9 😠

@unknownbrackets unknownbrackets merged commit a1ebc35 into hrydgard:master Apr 1, 2020
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Apr 1, 2020
@Florin9doi Florin9doi deleted the ios_notch branch April 1, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants