Check whether the audio is actually played in psmf player #12647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hrydgard#11898, some audio contained in pmf videos seem not be actually played by the games. current code prevents video from moving forward for waiting auido and sync, similar issue will happen.
|
So basically, the game never calls scePsmfPlayerGetAudioData? It indeed seems like it could get stuck this way then. Good find! I'd prefer if you rename your function IsActuallyPlayingAudio , but that's a minor thing. |
|
Yes, scePsmfPlayerGetAudioData never be called, renaming has been done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11898, some audio contained in pmf videos seem not be actually played by the games.
Current code prevents video from moving forward for waiting auido and sync, similar issue will happen.