Vulkan: Add missing barrier between multiple passes to the same target. #12224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in COLOR_OPTIMAL layout. Fixes #12215
|
Thank you very much hrydgard. |
|
This turned out to also fix a flicker issue in Star Wars: Force Unleashed. And probably more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Games are sometimes a bit silly and render a bit to one target, a bit to another, then go back and render more to the first. We need to tell Vulkan that there's a sequential dependency, otherwise the driver might try to execute the passes concurrently or out of order. ARM Mali notably does this in newer driver versions.
Fixes #12215.
There's also potential here for increasing performance by merging passes.