Remove outdated TrueColor setting. #11667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Seems reasonable. I'm concerned that people might be unhappy about the timer hack removal in #11666 and this mixes a change for that in, though.
-[Unknown]
Core/Reporting.cpp
Outdated
| @@ -458,8 +458,6 @@ namespace Reporting | |||
| bool IsSupported() | |||
| { | |||
| // Disabled when using certain hacks, because they make for poor reports. | |||
| if (g_Config.bTimerHack) | |||
There was a problem hiding this comment.
Oops, not meant for this PR.
-[Unknown]
There was a problem hiding this comment.
thanks, moved to the other PR.
hrydgard
force-pushed
the
remove-truecolor
branch
from
474beca to
a66ea45
Compare
hrydgard
force-pushed
the
remove-truecolor
branch
from
a66ea45 to
56bc7b1
Compare
|
Are you using this @Emulatorer or why the thumbs down on this one? |
unknownbrackets
approved these changes
Dec 14, 2018
|
Yeah I use it in some games but it seems no improvement in performance as i tested the latest git so.. changing thumbs down to thumbs up hehe 😅 |
vnctdj
added a commit
to vnctdj/ppsspp-lang
that referenced
this pull request
Apr 14, 2019
vnctdj
added a commit
to vnctdj/ppsspp-lang
that referenced
this pull request
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really no reason for this to exist anymore. Even if we can support low-bit-depth hardware rendering, noone will normally use it and it will go untested and eventually probably broken. Nobody renders at 16-bit color these days.