Debugger: Add APIs to retrieve render image #11186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents an assert.
Should be fine to request BGRA->BGRA. Also, the reverse flags were wrong/ignored on the format.
This is a decent chunk faster.
This allows pulling the display/target while paused. It may also allow other actions that work outside a display list.
Only works on desktop GL.
unknownbrackets
changed the title
|
Interesting about the bad stencil, I think I've had that working for the GE Debugger in Vulkan but maybe I'm thinking of DX11... |
|
Yeah, it works fine in Vulkan on desktop - it's only happening on mobile. -[Unknown] |
|
Ah okay, almost certainly driver bugs then, that we should probably report to the vendors.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the debugger using the GLES backend (on desktop GL) to show depth and stencil again.
Under Vulkan, I'm seeing wrong stencil (full for all pixels) for #10634, but haven't verified depth/stencil readback actually works on mobile Vulkan in the general case.
Using PNG encoding with lowest compression settings kept the speed relatively okay. Outside the GE debugger, you could imagine a "trophy app" that takes a screenshot whenever some breakpoint trips. And there's obviously the use case for translation tools.
-[Unknown]