Remove Qt debugger #11130
Merged
Remove Qt debugger #11130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Yeah, it's time. It's pretty interesting that the Windows GE debugger functions as well as it does, given its also rather hardcoded OpenGL use... |
|
Well, it just uses a totally separate GL instance to render zoomed textures and such - it would only really be an issue if a driver didn't support a separate thread having a GL context while a Vulkan context was in use. -[Unknown] |
Being replaced by new WeBsocket based debugger with better maintenance.
Being replaced by WebSocket based debugger which is better maintained.
Being replaced with WebSocket based debugger. Was disabled and not working anyway, and hardcoded some GL so a barrier to Vulkan.
Being replaced by WebSocket based debugger.
No longer worked anyway. Being replaced by WebSocket debugger.
unknownbrackets
force-pushed
the
qt-debugger
branch
from
a7287e1 to
ec398cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many parts were no longer functioning properly, and some were hardcoding OpenGL calls which is a barrier to proper Vulkan support on the Qt port.
The plan is to have a working debugger using websockets that supports all platforms, and have less risk of breaking Qt while improving that debugger.
Not planning to remove the Windows debugger anytime soon, as it's pretty stable. But I'd like to keep the refactoring effort down, especially since the Qt debugger wasn't really working anyway.
This also fixes Qt on Mac.
-[Unknown]