GPU: Prevent temp FBOs from overwriting each other #11007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we'd use two temp FBOs in the same draw (e.g. shader blending + depal.) This could cause the same temp FBO to get used for two purposes, causing weird behavior.
Otherwise it affects shader blending.
|
Yup, I started poking in this direction myself last night... Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dragon Ball Z uses shader blending (for the absolute difference stuff) and depal at the same time. Turns out we were reusing a temp FBO for both and this was causing weirdness.
This simply uses a
reasonin the cache key so we get two separate temp FBOs.ALSO: useShaderDepal on Vulkan causes the outline to be offset slightly. Not sure if it's a rounding / pixel center issue or what.
-[Unknown]