Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the flip delay in the other direction to try to work around #10763. #10944

Merged
merged 2 commits into from
Apr 29, 2018

Conversation

hrydgard
Copy link
Owner

This is getting extremely ugly...

@unknownbrackets
Copy link
Collaborator

Yeah... well, at least it doesn't appear to be incorrectly triggering in Jeanne d'Arc, Final Fantasy 4, or Tales of Phantasia.

-[Unknown]

@zminhquanz
Copy link
Contributor

It nearly finish , i think it's ready for release 1.6 version

@@ -713,6 +714,7 @@ void __DisplayFlip(int cyclesLate) {
// Check first though, might've just quit / been paused.
if (coreState == CORE_RUNNING) {
coreState = CORE_NEXTFRAME;
DEBUG_LOG(SCEDISPLAY, "No recent flip - displaying anyway.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This gets logged even for normal flips right?

-[Unknown]

@hrydgard
Copy link
Owner Author

I can't find any bad effects, let's go for it.

@hrydgard hrydgard merged commit 3537569 into master Apr 29, 2018
@hrydgard hrydgard deleted the another-gow-timing-hack branch April 29, 2018 07:46
@hrydgard
Copy link
Owner Author

hrydgard commented May 2, 2018

I'm gonna revert this and see if I can come up with something else...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants