GPU device choice for D3D11 and Vulkan #10922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core/Config.h
Outdated
| @@ -153,6 +153,9 @@ struct Config { | |||
|
|
|||
| // GFX | |||
| int iGPUBackend; | |||
| // We have separate device parameters for each backend so it doesn't get erased if you switch backends. | |||
| // If not set, will use the "best" device. | |||
| std::string VulkanDevice; | |||
There was a problem hiding this comment.
sVulkanDevice and sD3D11Device? We're kinda stuck with the convention now.
-[Unknown]
hrydgard
force-pushed
the
gpu-device-choice
branch
from
36554a0 to
238521a
Compare
|
Rebased on master, renamed the variable. |
unknownbrackets
approved these changes
Jun 6, 2018
|
I was expecting that restart will be needed but ppsspp doesn't say like for the renderer. Maybe a popup message will be nice. |
|
Created an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rather mindless coding on a train from earlier today, heh. Mostly useful for debugging the Intel implementations of these APIs when you happen to have a discrete GPU in your machine too.
Thinking about also making a fallback so you can also enter "1" or "2" to choose the first or second devices etc, if you can't guess the correct name when modifying the INI to rescue yourself from a broken driver situation, if that ever happens...