Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yugioh ppsspp stuck (corrupt save) #7914

Open
lordemort opened this issue Aug 22, 2015 · 160 comments
Open

yugioh ppsspp stuck (corrupt save) #7914

lordemort opened this issue Aug 22, 2015 · 160 comments

Comments

@lordemort
Copy link

hi guys
i'm new here and i'm using ppsspp v1.0.1
now i'm playing this yugioh gx tag force 1
everything is fine, the duel,the card,the field..
but there is 1 thing that bothers me, i can't save my game when i've been this far.
Everytime i save the game, it always stuck in checking memory card and it won't proccess any further,
and it does feel uncomfortable if i use "save state" option to save the game
please help me to solve this problem and recover my save
Thanks

@ppmeis
Copy link
Contributor

ppmeis commented Aug 24, 2015

@lordemort which version? Official or latest svn? device? Platform?

@lordemort
Copy link
Author

@ppmeis i'm using ppsspp for windows ver 1.0.1
its Yu-Gi-Oh Tag Force 1

when i save the game via the map it stuck in "checking memory card..."
others,like sound,animation, is still working normally, only the checking memory card screen just stuck there,also when i want to change my deck name it didn't show the alphabet keyboard on gray-background,so i just press change deck name and nothing happened

and also here is the log,
if i save via map,it stopped in "...wrong dialog type"
http://pastebin.com/0LHfj30b -->save via map
http://pastebin.com/gb31gANS -->deck name

@lordemort
Copy link
Author

anyone ?

@sum2012
Copy link
Collaborator

sum2012 commented Aug 27, 2015

Try newest version
http://buildbot.orphis.net/ppsspp/

@sum2012
Copy link
Collaborator

sum2012 commented Sep 13, 2015

Sorry lend this issue,
@unknownbrackets Does our (ppsspp) code already do this ?
jpcsp/jpcsp@bb60952

@unknownbrackets
Copy link
Collaborator

Yes, unloading a module unmaps it's exports.

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Sep 13, 2015

@unknownbrackets I see

@stealth62
Copy link

Hello sir sum2012 save dialog error still having in yugioh tag force

in ppsspp v1.0.1 i got this error HLE\sceUtility.cpp:123 sceUtilitySavedataInitStart(09c0c0f0): wrong dialog type
in yugioh tagforce 4.

now i tried the latest revision ppsspp v1.0.1-2668-g253ed9f found another problem HLE\sceUtility.cpp:129 sceUtilitySavedataInitStart(09c0c0f0): wrong dialog type
still not continuing save dialog in yugioh tagforce. please help us thank you

@sum2012
Copy link
Collaborator

sum2012 commented Sep 14, 2015

@stealth62 Did you use save status or cwcheat ?

@stealth62
Copy link

i didnt use cwcheat ,yes i use save status i only use save state because im afraid to lose the progress because i tried normal saving the save dialog stuck up.

@stealth62
Copy link

like lordemort said im not comfortable also in save state. but if not possible due to mismatch checksum made by save state ,corruption etc., Only save state available i'll understand sir.

@sum2012
Copy link
Collaborator

sum2012 commented Sep 15, 2015

What OS are you using ? (Windows XP,Windows vista,windows 7,etc )

@stealth62
Copy link

windows8.1 running in full administrator previleges

@sum2012
Copy link
Collaborator

sum2012 commented Sep 15, 2015

Back up savedata
then delete it.
run ppsspp
load the game
Then load status
try in-game save

@stealth62
Copy link

hello sir still having a problem in dialog
HLE\sceUtility.cpp:129 sceUtilitySavedataInitStart(09c0c0f0): wrong dialog type

@sum2012
Copy link
Collaborator

sum2012 commented Sep 15, 2015

Can you zip the whole "SAVEDATA" folder and "PPSSPP_STATE" folder
into https://drive.google.com/ ? Thanks

edit:copy bad save to my google drive https://drive.google.com/file/d/0B3OaSdeV0L8kejl4SnhjVTQxcE0/view?usp=sharing

@stealth62
Copy link

ok sir.

@stealth62
Copy link

sir thank you very much for your help.

@stealth62
Copy link

@stealth62
Copy link

here sir sorry for late upload

@sum2012
Copy link
Collaborator

sum2012 commented Sep 21, 2015

@stealth62 I have hacked the ppsspp 's code to make save file.
Can you test the save data is fixed ? Thanks
https://drive.google.com/file/d/0B3OaSdeV0L8kdjFwN0pkejhIbTQ/view?usp=sharing

@stealth62
Copy link

ok sir ty.

@stealth62
Copy link

its working but thats not the save file i used i remember i have 19000 dp not 14000k dp in yugioh game

@stealth62
Copy link

in normal save file i have 14k dp yugioh, in save state thats the latest save state i have 19k dp . When i load save state and save through game the save dialog stuck in yugioh screen.

@stealth62
Copy link

here sir my screenshot step by step how i load state.
https://drive.google.com/file/d/0B5rsaQWPmqEhbXdTdFFRNVROQ3M/view?usp=sharing

@sum2012
Copy link
Collaborator

sum2012 commented Sep 21, 2015

Sorry,I upload wrong game save
Can you test again ? Thanks
https://drive.google.com/file/d/0B3OaSdeV0L8kQkJIZUlid1pQdnM/view?usp=sharing

@stealth62
Copy link

sir sum2012 now working. thank you very much for your help .more power to come godbless

@sum2012
Copy link
Collaborator

sum2012 commented Sep 30, 2015

You can close this issue.
Anyway ,can you tell me how to reproduce bad save ?
eg:in-game->game save->duel->save status->load status->duel finish->cannot game save

@unknownbrackets
Copy link
Collaborator

So is this not an issue anymore? I'm not completely following the above...

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Jan 17, 2016

Yes ,there is no issue anymore,but I still no idea that how to reproduce bad save

@ghost
Copy link

ghost commented May 13, 2020

@hrydgard confirmed no more corrupt save using ppsspp v1.9.3-761 git build, tried and tested in Yu-Gi-Oh GX Tag Force 1 and Arc V Tag Force Special

@hrydgard
Copy link
Owner

OK, so should we just leave it like this?

@ghost
Copy link

ghost commented May 13, 2020

OK, so should we just leave it like this?

yes, also remove the outdated label.

@sum2012
Copy link
Collaborator

sum2012 commented May 13, 2020

If no more saving issue in v11 ,then I think that we can delete the hack code.

@hrydgard
Copy link
Owner

Sounds good.

@hrydgard hrydgard added this to the v1.11.0 milestone May 13, 2020
@SessentaRV
Copy link

SessentaRV commented Jul 24, 2020

Hello @sum2012 can you help me?? Im having exactly the same OP's problem, i saw that you fixed alot of saves from alot of people here, can you also fix mine?? I was in the last day of the part 1, when i was going to part 2 i got cutted by the save bug :/

I already tried using the newest PPSSPP version, it didnt work.

@sum2012
Copy link
Collaborator

sum2012 commented Jul 24, 2020 via email

@SessentaRV
Copy link

SessentaRV commented Jul 24, 2020

can you tell me what is your ppsspp's version ? 在 2020年7月24日週五 15:10,SessentaRV [email protected] 寫道:

Hello @sum2012 https://github.com/sum2012 can you help me?? Im having exactly the same OP's problem, i saw that you fixed alot of saves from alot of people here, can you also fix mine?? I was in the last day of the part 1, when i was going to part 2 i got cutted by the save bug :/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7914 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7E3YZBYIZKAARZLB4DR5EXWVANCNFSM4BOBIVKA .

I played all the game on 1.9.3-998 until the last day of the part 1, then the save's bug appeared. So i tried to run on 1.10.3, but it didnt work, the bug continued.

Oh, the game is Yugioh GX Tag Force 1, i forgot to mention.

@sum2012
Copy link
Collaborator

sum2012 commented Jul 24, 2020 via email

@SessentaRV
Copy link

please temp use v1.9.3-760-gf23dd7635 or before version. We have disabled " YuGiOh save fix "for experiment 在 2020年7月24日週五 15:24,SessentaRV [email protected] 寫道:

can you tell me what is your ppsspp's version ? 在 2020年7月24日週五 15:10,SessentaRV @.*** 寫道: … <#m_-5337997085184197892_> Hello @sum2012 https://github.com/sum2012 https://github.com/sum2012 can you help me?? Im having exactly the same OP's problem, i saw that you fixed alot of saves from alot of people here, can you also fix mine?? I was in the last day of the part 1, when i was going to part 2 i got cutted by the save bug :/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7914 (comment) <#7914 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7E3YZBYIZKAARZLB4DR5EXWVANCNFSM4BOBIVKA . I played all the game on 1.9.3-998 until the last day of the part 1, then the save's bug appeared. So i tried to run on 1.10.3, but it didnt work, the bug continued. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7914 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQTT7DGDPMHJXGUQVX7O3TR5EZLNANCNFSM4BOBIVKA .

Wow, in this version my save is running fine. Thank you :)

@sum2012
Copy link
Collaborator

sum2012 commented Jul 25, 2020

@SessentaRV edit: Nothing

@sum2012
Copy link
Collaborator

sum2012 commented Jul 25, 2020

@hrydgard @unknownbrackets He used v1.9.3-998-gc739d4e16 but still have saving problem.
Do we need revert the "YuGiOh save fix " code ?

@unknownbrackets
Copy link
Collaborator

Depends on how it was reproduced.

The problem is, when you open a dialog, the PSP firmware doesn't allow you to open a second dialog until the first one is closed. In part, this is because of memory allocation and other things - it can't manage both at the same time.

We had a bug in the network dialog that made it forget to "close" the dialog. Even though it was no longer displayed, the dialog was still considered open. This prevented opening any other dialog, including save dialogs.

The fix makes it so when the dialog is supposed to close, it is actually recorded as closed correctly. So now, if you never use an old version of PPSSPP, you should (hopefully) never have the problem. If the network dialog shows, it will get closed.

However, the fix doesn't help you if you already used an old version, and in this old version you opened the network dialog. The old version would not have recorded the dialog closing properly, and so even if you load the save state in a newer PPSSPP, the bug is preserved. The dialog will still be "open" and prevent any other dialog from opening.

So: if the bug was reproduced on an old version of PPSSPP, it's expected that using a newer version will not fix it. Was the bug reproduced on a newer version without ever using an old version of PPSSPP for that save state?

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented Jul 25, 2020

@SessentaRV When you first play yugioh ,do you version is really v1.9.3-998-gc739d4e16 ?

@SessentaRV
Copy link

@sum2012 Yes, i started playing exactly in this version until the bug appeared.

@hrydgard hrydgard modified the milestones: v1.11.0, Future Nov 26, 2020
@danu394
Copy link

danu394 commented Jun 14, 2021

Any update?

@danu394
Copy link

danu394 commented Jun 14, 2021

I use android version, and dont find folder call combat.ini

@danu394
Copy link

danu394 commented Jun 14, 2021

@danu394
Copy link

danu394 commented Jun 14, 2021

@sum2012 help me

@Saramagrean
Copy link
Contributor

I use android version, and dont find folder call combat.ini

@danu394 I think you can override compat.ini in PSP/SYSTEM/compat.ini.

Download this file & put in folder PSP/SYSTEM.

@ghost
Copy link

ghost commented Sep 1, 2021

This is still an issue @SessentaRV ?

@unknownbrackets
Copy link
Collaborator

The best way to help get this fixed would be to try to find the shortest path to reproducing it. Specifically:

  • Latest or recent git build.
  • Absolutely no use of save states whatsoever.
  • Debug logging enabled.

The most perfect scenario would be starting the game, and triggering this issue of being unable to save within 2 minutes. This would produce a long log, but it would be viable to search through it and potentially figure out the cause.

If you do encounter this issue, you can workaround it temporarily (between v1.9.3-761-g0e5957e67 and possibly v1.12 or so.)

  1. Create a file named "compat.ini" inside PSP/SYSTEM (next to ppsspp.ini.)
  2. Add the following content:
    [YugiohSaveFix]
    ULJM05151 = true
  3. Change the "ULJM05151" in the content to the game ID of the game you're playing.
  4. Restart PPSSPP (you may want to save state and load your state after the restart.)

@Gamemulatorer when you noted that this is still an issue, did you reproduce it without any save states whatsoever on a recent git build?

-[Unknown]

@ghost
Copy link

ghost commented Sep 5, 2021

@Gamemulatorer when you noted that this is still an issue, did you reproduce it without any save states whatsoever on a recent git build?

-[Unknown]

No I'm asking @SessentaRV if he can still reproduce this issue 😅

@ghost
Copy link

ghost commented Sep 15, 2021

Curious why is this tag as Network/Adhock and not Saving Issue :)

@unknownbrackets
Copy link
Collaborator

It was (I believe) caused by networking code corrupting state and preventing other dialogs, like the save dialog, from running. That would mean it's not possible to hit if you don't have networking enabled. The real fix was in networking code.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.