-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 small errors in the BLEACH HEAT OF SOUL 6 [UCAS40258] in the version 0.9.9 and BUILD #6627
Comments
For the crash |
The save thing should be fixed now. Does the crash still happen in the latest PPSSPP git build? -[Unknown] |
v1.7.5-553-gc77af182a crash before menu debug log: https://drive.google.com/file/d/1H_oKJ7sdy3LGG1XAvn_cJ7qWU-ZHB6on/view?usp=sharing crash trace
|
Hm, could maybe be out of bounds of the src or the destination of the blit, possibly? We have some clipping code in the Vulkan path that we maybe should use on all backends. |
It only crash on Opengl. |
Hmm, aspectMask there is GL_STENCIL_BUFFER_BIT. I wonder where we're trying to blit depth without z - that's definitely a bug. -[Unknown] |
Also fixes crashes on ATI. See hrydgard#6627.
Sorry, #11873 should fix that now. -[Unknown] |
Oh good catch! That goes in 1.8.0. And thanks for the bisect @sum2012 ! |
Thanks @unknownbrackets @hrydgard 58:49:061 Main W[MEMMAP]: MemmapFunctions.cpp:92 ReadFromHardware: Invalid address 00000000 full log: https://drive.google.com/file/d/1tRPbyxC-SrJf9X-3q1Sj7MolLsy_gGFO/view?usp=sharing I try to hack to allow the close font ,but crash in the other place. |
Hm. Those errors are between Basically, we're calling freeFuncAddr from Does it help to make the below change? // TODO: The return value of this is leaking.
__KernelDirectMipsCall(params_.freeFuncAddr, 0, args, 2, false); To: if (handle_) {
// TODO: The return value of this is leaking.
__KernelDirectMipsCall(params_.freeFuncAddr, 0, args, 2, false);
} -[Unknown] |
That change is almost certainly good - calling a callback a second time on a double-free can't be right. |
Well done @unknownbrackets @hrydgard full log: https://gist.github.com/sum2012/fbf6354c2c965e211f9685eb070b5725 |
Good. I don't think that error output is much to worry about. |
Now no error on this game. |
40:51:183 Main E[FONT]: HLE\sceFont.cpp:626 Font exists but is closed, which was not allowed in this call.
40:51:183 Main E[FONT]: HLE\sceFont.cpp:908 sceFontClose(8e06f1c) - font not open?
40:51:183 Main E[FONT]: HLE\sceFont.cpp:626 Font exists but is closed, which was not allowed in this call.
40:51:183 Main E[FONT]: HLE\sceFont.cpp:908 sceFontClose(8e06f68) - font not open?
The text was updated successfully, but these errors were encountered: