Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrie Profile Lenneth USA - ULUS10107 -crash in ending A movie #6008

Closed
whatisthat opened this issue May 3, 2014 · 28 comments
Closed

Valkyrie Profile Lenneth USA - ULUS10107 -crash in ending A movie #6008

whatisthat opened this issue May 3, 2014 · 28 comments
Labels
PSMF / MPEG Issue involves scePsmf or sceMpeg video playback.

Comments

@whatisthat
Copy link

HI please help
this one is realy bad
it crash in the last video !!!

valkyrie_profile_lenneth_usa

@dbz400
Copy link
Contributor

dbz400 commented May 3, 2014

Can you give more detail here ? which last video?

@unknownbrackets
Copy link
Collaborator

Savedata or something would help.

-[Unknown]

@whatisthat
Copy link
Author

in the last of ending A after killing loki (last boss) there is a video
after finishing this video game crash. savedata and savesatate both crashes
I am using 0.9.8-561
savedata:
https://www.transferbigfiles.com/6ed82a03-d51f-4986-b4f5-dc9a4827cb9c/NEPbTzcU3qCULbQy2GK7Wg2
v2

@whatisthat whatisthat changed the title Valkyrie Profile Lenneth USA crash in ending A movie Valkyrie Profile Lenneth USA - ULUS10107 -crash in ending A movie May 3, 2014
@unknownbrackets
Copy link
Collaborator

This game is depending on, like Super Danganronpa (psmfplayer) and iirc Gods Eater Burst (also mpeg), the first frame of the video not being written. I actually mentioned this a long time ago, but it was reverted for some reason.

What it's specifically doing is writing some important address into memory at 0x093D3A7C, and then trying to decode the video on top of it (which is surely just lazy coding.) Since it shouldn't actually write the video stream the first time around, it can then read that important address and all is well. But in PPSSPP, we write the video stream the first time around, replacing this important address with garbage.

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented May 4, 2014

Why the damage is 0 ?
1

@whatisthat
Copy link
Author

okay
should i wait for next releases of ppsspp or go back to previous versions to finish this one.

@sum2012
Copy link
Collaborator

sum2012 commented May 4, 2014

@whatisthat I see

@Firefeather-rebirth
Copy link

Kinda' disappointing, it is? playing hard mode all along, and we have this situation in the end. But actually the game is clear, after all--we just can't find the last movie in gallery.
good news is, I find no problem in accessing Seraphic Gate.

I think we should wait for next version.
I've trying with 0.9.6.2 but the result is still pretty same.

@jiayiming
Copy link

ppsspp-v0.9.6-338-g367a5b7-windows-x86 can play the ending movie,but after the movie ppsspp can't go on......

@sum2012
Copy link
Collaborator

sum2012 commented Jul 28, 2014

v0.9.9-34-gb7ac539-windows-amd64
same problem

I upload the save to google drive
https://drive.google.com/file/d/0B3OaSdeV0L8kTE9OZ0VoRzZZb0U/edit?usp=sharing

@klinekline
Copy link

This is a problem again in 1.01

Please fix this simple issue again as per above.

@unknownbrackets
Copy link
Collaborator

So, I'm making progress on fixing this. I had to change the way we demux somewhat, and tweak framebuffer sizing, and it also fixes the corruption in the intro video so far. But it's got bugs.

Still trying to zero in on the delay timing. I think it relates to the h264 frame size.

For example, the intro video puts 1 * 2048 bytes at a time. It returns an error code for the first 9, and on the 10th returns an AU successfully. The first h264 frame is 19258 bytes, which matches up. If FFmpeg is given a partial packet of this frame, it'll decode truncated macroblocks and show garbage on the screen.

It still returns an error code decoding on the 10th frame, but succeeds on the 11th. It then has an additional frame of latency before producing a picture on the 12th.

The ending puts 32 * 2048 bytes at a time, and its first h264 frame is only 162 bytes. In its case, it seems to still have one frame of latency before it produces a picture, but never any error codes.

Right now, I have it working by using a mid-size delay, but that will break other games. I guess next I need to figure out how to determine the full size of an h264 frame, or at least if a complete one exists in a buffer...

-[Unknown]

@unknownbrackets unknownbrackets added the PSMF / MPEG Issue involves scePsmf or sceMpeg video playback. label Jun 6, 2016
@unknownbrackets
Copy link
Collaborator

Ah, it becomes clearer:

http://stackoverflow.com/questions/24428839/how-to-find-any-of-i-b-p-frames-in-h264

Perhaps we can detect simply based on the 00 00 01 09 start codes in the demuxed video stream...

-[Unknown]

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Jul 24, 2016
Helps the ending video in Valkyrie Profile.  See hrydgard#6008.
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Jul 24, 2016
Helps the ending video in Valkyrie Profile.  See hrydgard#6008.
@benderscruffy01
Copy link

has this been fixed ???

@unknownbrackets
Copy link
Collaborator

No, I haven't really mucked with the video stuff for a while. f7cbe54 I believe fixed this, but broke other games in complicated ways.

-[Unknown]

@fedy77
Copy link

fedy77 commented Oct 21, 2020

Hi ,it's passed more time.....i palyed this beautiful game again,after i played it on PSP,but me too game crush on final title ending ,sometimes changed??Anyone have resolve the truble????thanks
No update of program came out....:)

@ghost
Copy link

ghost commented Oct 2, 2021

Anyone just try to add this game id to [MpegAvcWarmUp] compat.ini and see if it's help this issue.

@Maikao1
Copy link

Maikao1 commented Oct 15, 2021

Anyone just try to add this game id to [MpegAvcWarmUp] compat.ini and see if it's help this issue.
IT WORKED!!! TY SOO MUCH!! to anyone that want to fix this issue i`ll post the edited file. the version of the game is ULUS10107
Captura de tela 2021-10-15 180741

@ghost
Copy link

ghost commented Oct 15, 2021

IT WORKED!!! TY SOO MUCH!! to anyone that want to fix this issue i`ll post the edited file. the version of the game is ULUS10107

Captura de tela 2021-10-15 180741

Nice to know that it works ;)
Can you share your save state here on gitub? before the ending movie, I want to try it. TY

hrydgard added a commit that referenced this issue Oct 18, 2021
@Maikao1
Copy link

Maikao1 commented Oct 19, 2021

IT WORKED!!! TY SOO MUCH!! to anyone that want to fix this issue i`ll post the edited file. the version of the game is ULUS10107

Captura de tela 2021-10-15 180741

Nice to know that it works ;) Can you share your save state here on gitub? before the ending movie, I want to try it. TY

sure! but how can i do this idk

@Maikao1
Copy link

Maikao1 commented Oct 19, 2021

IT WORKED!!! TY SOO MUCH!! to anyone that want to fix this issue i`ll post the edited file. the version of the game is ULUS10107

Captura de tela 2021-10-15 180741

Nice to know that it works ;) Can you share your save state here on gitub? before the ending movie, I want to try it. TY

sure! but how can i do this idk

https://github.com/Maikao1/Maikao1/blob/main/PPSSPP_STATE.rar
i think is this u want, lemme know if its right btw in this save state the boss is already dead so u dont need to press nothing just apreciate one of the most iconic and nostalgic limit break of all RPG`s TY FOR EVERYTHING!!

@ghost
Copy link

ghost commented Oct 20, 2021

https://github.com/Maikao1/Maikao1/blob/main/PPSSPP_STATE.rar i think is this u want, lemme know if its right btw in this save state the boss is already dead so u dont need to press nothing just apreciate one of the most iconic and nostalgic limit break of all RPG`s TY FOR EVERYTHING!!

Unfortunately still crashing on me using your save state.

@Maikao1
Copy link

Maikao1 commented Oct 20, 2021

https://github.com/Maikao1/Maikao1/blob/main/PPSSPP_STATE.rar i think is this u want, lemme know if its right btw in this save state the boss is already dead so u dont need to press nothing just apreciate one of the most iconic and nostalgic limit break of all RPG`s TY FOR EVERYTHING!!

Unfortunately still crashing on me using your save state.

have u edited the file compat.ini?

@ghost
Copy link

ghost commented Oct 20, 2021

https://github.com/Maikao1/Maikao1/blob/main/PPSSPP_STATE.rar i think is this u want, lemme know if its right btw in this save state the boss is already dead so u dont need to press nothing just apreciate one of the most iconic and nostalgic limit break of all RPG`s TY FOR EVERYTHING!!

Unfortunately still crashing on me using your save state.

have u edited the file compat.ini?

It's already added on the latest git see 258a96a

@ghost
Copy link

ghost commented Oct 22, 2021

Here's the crash log using your save state Maikao1

ModuleThread E[JIT]: JitCommon/JitBlockCache.cpp:558 Bad InvalidateICache: 08f7eb6b with len=-768

dump
ppsspp.ppdmp.zip

@ghost
Copy link

ghost commented Apr 15, 2022

Doesn't crash now again :)
Sad movie ending :(
https://youtu.be/_o7mYCSu-tU

@Maikao1
Copy link

Maikao1 commented Dec 6, 2022 via email

@hrydgard
Copy link
Owner

hrydgard commented Dec 6, 2022

Yeah, this is one of a bunch of similar issues due to the same mpeg problem. We can close this individual one.

@hrydgard hrydgard closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PSMF / MPEG Issue involves scePsmf or sceMpeg video playback.
Projects
None yet
Development

No branches or pull requests