-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valkyrie Profile Lenneth USA - ULUS10107 -crash in ending A movie #6008
Comments
Can you give more detail here ? which last video? |
Savedata or something would help. -[Unknown] |
in the last of ending A after killing loki (last boss) there is a video |
This game is depending on, like Super Danganronpa (psmfplayer) and iirc Gods Eater Burst (also mpeg), the first frame of the video not being written. I actually mentioned this a long time ago, but it was reverted for some reason. What it's specifically doing is writing some important address into memory at 0x093D3A7C, and then trying to decode the video on top of it (which is surely just lazy coding.) Since it shouldn't actually write the video stream the first time around, it can then read that important address and all is well. But in PPSSPP, we write the video stream the first time around, replacing this important address with garbage. -[Unknown] |
okay |
@whatisthat I see |
Kinda' disappointing, it is? playing hard mode all along, and we have this situation in the end. But actually the game is clear, after all--we just can't find the last movie in gallery. I think we should wait for next version. |
ppsspp-v0.9.6-338-g367a5b7-windows-x86 can play the ending movie,but after the movie ppsspp can't go on...... |
v0.9.9-34-gb7ac539-windows-amd64 I upload the save to google drive |
This is a problem again in 1.01 Please fix this simple issue again as per above. |
So, I'm making progress on fixing this. I had to change the way we demux somewhat, and tweak framebuffer sizing, and it also fixes the corruption in the intro video so far. But it's got bugs. Still trying to zero in on the delay timing. I think it relates to the h264 frame size. For example, the intro video puts 1 * 2048 bytes at a time. It returns an error code for the first 9, and on the 10th returns an AU successfully. The first h264 frame is 19258 bytes, which matches up. If FFmpeg is given a partial packet of this frame, it'll decode truncated macroblocks and show garbage on the screen. It still returns an error code decoding on the 10th frame, but succeeds on the 11th. It then has an additional frame of latency before producing a picture on the 12th. The ending puts 32 * 2048 bytes at a time, and its first h264 frame is only 162 bytes. In its case, it seems to still have one frame of latency before it produces a picture, but never any error codes. Right now, I have it working by using a mid-size delay, but that will break other games. I guess next I need to figure out how to determine the full size of an h264 frame, or at least if a complete one exists in a buffer... -[Unknown] |
Ah, it becomes clearer: http://stackoverflow.com/questions/24428839/how-to-find-any-of-i-b-p-frames-in-h264 Perhaps we can detect simply based on the 00 00 01 09 start codes in the demuxed video stream... -[Unknown] |
Helps the ending video in Valkyrie Profile. See hrydgard#6008.
Helps the ending video in Valkyrie Profile. See hrydgard#6008.
has this been fixed ??? |
No, I haven't really mucked with the video stuff for a while. f7cbe54 I believe fixed this, but broke other games in complicated ways. -[Unknown] |
Hi ,it's passed more time.....i palyed this beautiful game again,after i played it on PSP,but me too game crush on final title ending ,sometimes changed??Anyone have resolve the truble????thanks |
Anyone just try to add this game id to [MpegAvcWarmUp] compat.ini and see if it's help this issue. |
…round ending crash. See issue #6008
https://github.com/Maikao1/Maikao1/blob/main/PPSSPP_STATE.rar |
Unfortunately still crashing on me using your save state. |
have u edited the file compat.ini? |
It's already added on the latest git see 258a96a |
Here's the crash log using your save state Maikao1
dump |
Doesn't crash now again :) |
yes, thank you!
…________________________________
De: benderscruffy ***@***.***>
Enviado: quarta-feira, 30 de novembro de 2022 04:54
Para: hrydgard/ppsspp ***@***.***>
Cc: Maikao1 ***@***.***>; Comment ***@***.***>
Assunto: Re: [hrydgard/ppsspp] Valkyrie Profile Lenneth USA - ULUS10107 -crash in ending A movie (#6008)
can this be closed now ???
—
Reply to this email directly, view it on GitHub<#6008 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWCRE7SNTSYFEUXV57UXB53WK3MXRANCNFSM4AO6YL5A>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Yeah, this is one of a bunch of similar issues due to the same mpeg problem. We can close this individual one. |
HI please help
this one is realy bad
it crash in the last video !!!
The text was updated successfully, but these errors were encountered: