Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture replacement priority regression #18465

Closed
hrydgard opened this issue Dec 2, 2023 · 1 comment
Closed

Texture replacement priority regression #18465

hrydgard opened this issue Dec 2, 2023 · 1 comment
Labels
Texture replacement
Milestone
v1.17.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Dec 2, 2023 •
edited
Loading

Reported on Discord by ]Silver ❄「Suzuna」:

It seems that in the past, in this case:

  • Texture 0962ec60df1a2fba49d1f4e8
  • 0962ec60df1a2fba49d1f4e8.png present in root
  • The line 0962ec60df1a2fba49d1f4e8 = Map/Villa/Yukumo16.png present in ini

We previously prioritized the named PNG, but now the hash-named one in the root has priority. This isn't intentional and should probably be fixed.
@hrydgard hrydgard added this to the v1.17.0 milestone Dec 2, 2023
hrydgard added a commit that referenced this issue Dec 2, 2023
@hrydgard
Texture replacement: Prioritize ini file lines over files in the "root".
7f67a10 
This reverts back to the old behavior, as mentioned in #18465
@hrydgard hrydgard mentioned this issue Dec 2, 2023
Merged
@hrydgard
Copy link
Owner Author

hrydgard commented Dec 3, 2023

Closing, fixed by #18466.

@hrydgard hrydgard closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Texture replacement
Projects
None yet
Milestone
v1.17.0
Development

No branches or pull requests
1 participant
@hrydgard