Redump ISO conflicts

[Panderner]

There some conflicts for some games verified on Redump that cause the ISO is listed as Incorrect CRC or game ID unknown due to actual use of Internal Serial.

For example Gundam vs. Gundam Next Plus listed as NPJH-50107 (http://redump.org/disc/33346/)

and Dragon Ball Evolution Asian Version uses US game ID of ULUS-10415 (http://redump.org/disc/26306/)

[Panderner]

Chronicle of Dungeon Maker does not have an entry for japanese version but the asia dump exist that uses ULJM-05172 (http://redump.org/disc/3146/)

[LunaMoo]

That database included in PPSSPP seems to only have what the site calls "serial"(I guess what's on the box in various releases), but the only data we have is what it calls "internal serial" aka the actual stuff we can see.

In cases where ID is unknown it just means none of the "box" Id's from the database is the real game ID which we can read from the param.SFO.
In cases of wrong CRC by missdetection, it means various versions of the game shared same real ID and only the one which real game ID matches box game ID is considered correct.

So the database included now feels pretty bad and just incorrect. To make it actually usable we would have to get database with real game ID's and make sure to check for all cases of correct CRC's for each gameID as various copies apparently can share one game ID.

[hrydgard]

There's been mentions of a future db update in the meantime which will fix this. Until then, we at least now have the framework and its better than nothing for the most part.

But yes, really good to collect problems found here, we could load a secondary fixup db on top for example.

[LunaMoo]

Probably the feature will be most prone to problems in regional versions from europe and asia, but this will also fail for many updated games and psn versions from within major regions(us/eu/jp), literally first game in that database is an 1.01 version of a japanese game which fails to match in PPSSPP.

Maybe the warning/error should be worded differently to not be soo black and white about it being bad CRC at least until the database actually get's fixed.

[hrydgard]

Some good points. Thinking about changing the check order so we first use ID to check size as before, but then when you calculate the CRC, it'll match the CRC found against all known CRCs. That should remove some issues with serials being wrong.

Anyway, thanks for the feedback, I think I had to merge this to get that feedback :) We'll tweak this until it's as good as it can be with the current database, while waiting for database fixes.

[padoverc]

The Back button is showing under the Redump check. I think it should be under the button like everything else.

[diego-rbb-93]

Already reporting my mates about this. I already told Hrydgard that Redump.org still lacks a ton of Asian/Japanese/Korean releases. Sadly, these markets published a ton of regional releases/exclusives/alternative editions.

Yes, it seems we should run a script to extract the Internal Serials from the existing fullset and send a customized list for it.

However, as I was saying, Redump.org tries to provide better documentation and clean metadata for these discs. If you find out releases that haven't been added to Redump, we would be happy to receive support in order to have them added:

http://wiki.redump.org/index.php?title=Discs_not_yet_dumped#Sony_PlayStation_Portable

The thing is the Scene dumped most of the existing Japanese fullset, which is available around the net. All this data was datted by No-Intro back on those days, as both project started to work together, we created a "Non Official Redump" dat (in No-Intro) for this old data, that gets deprecated as soon as a disc gets a fresh dump on Redump (in some cases, the dump provided by the Scene was bad).

Between both databases, you could actually verify nearly all the existing releases, but it wouldn't be fair: The target is to put Redump as a valid checker for the user. For this reason, we keep seeking to redump all those titles and that's going to need a lot of time to be solved.

[Deterous]

This is a known issue: #12469 (comment)
It is a side effect of the current database using printed disc serial rather than internal serial.
Unfortunately "internal serial" is not present on older entries, so the redump.org db does not contain internal serial for all entries.
This would need to be scraped by someone outside of redump.

[hrydgard]

Alright. I might disable this again temporarily, or limit it to certain regions.

My goal is to have an easy way to let users check that their ISOs are not corrupt, and to show something on crash screens. This is to reduce bug reports caused by bad ISOs of course, which is way too common.

[LunaMoo]

Instead of limiting regions or disabling maybe just limit it to positive feedback. So it will show when the game was confirmed to be OK by the database, but not show anything in other cases.

[hrydgard]

I went ahead and removed all the "negative" messages for now.

[Panderner]

Some USA versions of digital games uses same game id as the physical version.

For example: Digital version of DJ Max Portable 3rd uses ULUS-10538