-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saint Seiya Omega Missing Character (GLES2) #1808
Comments
Yes, we know. They're gone after we fixed Ridge Racer, and I really don't understand why :( |
Hmm, can you paste a link to a frame dump for that? -[Unknown] |
Here is the link of frame dump .Generated using latest source |
Looks like a typical case of the Z buffer not getting cleared... why, I don't know. |
It requires depthWrite always set to TRUE in clearmode to fix the issue propertly "glstate.depthWrite.set(GL_TRUE);" for both Saint Seiya and Gundam AGE Universe. |
That's a hack, not a proper fix. The game seems to request depth writes to be off, so it doesn't make sense to turn it on. |
This bug is fixed. |
I think this bug is back. :( Reported in: |
Yes I can confirm It . |
@unknownbrackets Since it is a hack, should the bug continue open to remember to fix without hack? |
Well, I personally consider "having to use a hack" a bug, so e.g. I would consider bugs that said "Game X only works with buffered rendering off" or "Game X only works with depth write forced on" or etc. valid. Thus, to me, this continues to be a bug unless someone wants to close it just to open a new one and replicate the same detail, but about having to use a hack. That said, if there are multiple games that work only with this hack, it may be better to put them all into one new bug and close the individual bugs, unless they are just coincidences. Again, personally, I would only close a bug for good as fixed with a hack if I did not plan/expect to ever fix the issue correctly. For example, if the thing was simply not possible using OpenGL, and we had done the best approximation possible, but had a hack to use an alternative approximation that some games require, then a bug doesn't necessarily help that situation. -[Unknown] |
Not on Android though I guess... yet. |
Does this work any better on mobile now without any hacks enabled? We recently fixed some depth issues. Or, maybe it still requires the depth buffer to be retained, like Jeanne d'Arc. -[Unknown] |
This one is fixed by depth buffer copy, IIRC, and is still broken without it. |
yeah this one only work whit hack setting. |
On my Androd 4.3 with OpenGL 3.0 , depth copy is working good .Both Jeanne d'Arc and Saint Seiya can see the characters. |
It requires GL_EXT_framebuffer_blit / GLES 3.0. We could maybe try glBlitFramebufferEXT where supported. By the way, this is the case also for the Brave Story issue. Aside from trying to split the depth to a separately tracked buffer or manage attachments dynamically or something, we could also try blitting using a separate render pass, which is probably basically what glBlitFramebuffer does. -[Unknown] |
I'm wondering if still any ppl got invisible character here on his mobile device with unsupported GL_EXT_framebuffer_object on ES 2.0? (i think whenever GL_EXT_framebuffer_object presents , we should use glBlitFramebufferEXT or just simply glBlitFramebuffer?) |
Humm seen a user in forum mentioning it is not working for him and he is using Tegra Note 7 ......(Tegra 4 Soc) |
still need force depth write hack enabled on iphone 5S also why show ES 2.0 in system information? iphone 5S is ES 3.0 |
Hm, I think we need to add some code to request ES 3.0 support when initializing OGL on iOS. |
ios 7.0.6 i dont have a MAC,cant compile. help here,please. |
A new PPSSPP (Testing) build will be available from KarenBuildBot in about two hours. Sorry for the unusual delay, it's down for maintenance because some I'm making some Cydia/APT address for my repo, Karen's Pineapple Repo: http://cydia.angelxwind.net/ Download page for my PPSSPP builds (iOS, Android, OS X, Linux): http://ppsspp.angelxwind.net/?page/downloads KarenBuildBot package index for those who are curious: http://karenbuildbot.angelxwind.net/ |
contain the new fixes for opengl 3.0 for iphone 5S? thx |
merge the changes and karen can compile it. thx |
KarenBuildBot is back up, latest commit for the master branch was just built. @raven02's OGLES3 commit hasn't been merged yet (see the page for pull request 207 hrydgard/native#207) |
@raven02 The Tegra Note 7 (Tegra 4) is Not OpenGL ES 3 capable. Only PoverVR Series 6, Adreno 3xx, and Mali T6xx/7xx support GLES3. |
It is a shame that Tegra 4 is a pretty new Soc but doesn;t support ES 3.0 .Wondering if it is not currently support in 4.3 but available in 4.4 |
The hardware itself is not capable. Tegra K1 should support it though when it starts getting used. |
I see. I have asked the user dumped the OGL extension and found a GL_NV_framebuffer_blit that we are not providing support yet . I will make a pull to see if can do something here |
We've biltted depth and color buffer.Wondering if bilt stencil buffer would help some games like midnight club 4? Not too sure if someone already tested but not helping. Probably I can do some.testing here. |
henrik merge hrydgard/native#207 but iphone 5S still didnt use ES 3.0. still needed force depth write hack why? |
@brujo5 iphone 5S doesn't have required extenshions for this fix to work anyway, so doesn't matter what ES version it'll use, you'll have to continue using the hack on this device. Edit: Oh well, I only looked at this short list here: https://developer.apple.com/library/ios/documentation/DeviceInformation/Reference/iOSDeviceCompatibility/OpenGLESPlatforms/OpenGLESPlatforms.html |
I think we need to do something extra on iOS to get ES 3.0, something like CreateBestEAGLContext here: iOS has full ES 3 support so glBlitFramebuffer should be available as it's core functionality, we just need to do the initialization correctly. |
The user who owns Tegra Note 7 reported that the character can be shown up now however missing powerbar and other stuffs |
fixed thx to @rock88 for add ES3.0 for ios no needed depth write hack anymore. |
Heh. Nice to see you around again, @rock88 c: |
For OpenGL 2.0 need to Enable always depth writte hack. |
Depth write hack is enabled and I have the same result |
Sorry for my bad English. The same result when Depth write hack is enabled. It happens only when I'm using my cellphone, and my GPU model is Mali-450MP. |
Nothing left to do, we can't solve this in a good way for ES 2.0. |
Saint Seiya Omega model become invicible again on this version until now (this work fine on v0.7.6 build).
The text was updated successfully, but these errors were encountered: