Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] [GLES 2] [Depth/Z] Ys SEVEN (ULUS10551) smoke going through the wall #12964

Closed
ghost opened this issue May 24, 2020 · 17 comments
Closed

Comments

@ghost
Copy link

ghost commented May 24, 2020

What happens?

Idk how exactly to explain properly this issue
but here's a screenshot for comparison

PPSSPP
Screenshot_20200524-214611

PSP
Screenshot_20200524-215509
Source: https://youtu.be/hW5Wp_WT-PM

What should happen?

No graphics glitch overlay?

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Android 6.0.1
Mali-450 GPU
OpenGL ES 2.0
PPSSPP v1.9.3-941

My Settings

Simulated Block Transfer Effects - ON
Buffered Rendering Mode
Rendering Resolution - x2
Device Resolution - Native
Hardware Transform - ON
Software Skinning - ON
Vertex Cache - OFF

GE Dump
ULUS10551.zip

@ghost
Copy link
Author

ghost commented May 24, 2020

@unknownbrackets looks correct on SW rendering mode
Screenshot_20200524-221858

@ghost ghost changed the title Ys SEVEN (ULUS10551) graphics glitch overlay [Android] [OpenGL] Ys SEVEN (ULUS10551) graphics glitch overlay on rites of demise stage May 24, 2020
@Panderner
Copy link
Contributor

Panderner commented May 24, 2020

PSP
Screenshot_20200524-215509
Source: https://youtu.be/hW5Wp_WT-PM

@Gamemulatorer that video source isn't a footage running on a real PSP they running this on a Emulator.

@unknownbrackets
Copy link
Collaborator

That dump plays back as this:

ULUS10551_#12964_missing_wall

Although, I'm seeing a bug while replaying this dump (in the dump's creation), so I'm not sure.

Do you have nearby save data? Can you tell me exactly how to get to this place so I can see it on a PSP?

-[Unknown]

@ghost
Copy link
Author

ghost commented May 25, 2020

@unknownbrackets I downloaded my savesdata from here https://gamefaqs.gamespot.com/psp/958946-ys-seven/saves and select Save before last boss. Normal mode.

@unknownbrackets
Copy link
Collaborator

Hm. For me, it does look pretty much like the "PSP" area, but it looks the same in Vulkan and OpenGL for me.

Here's a dump (you can open this and see it render on your device):
ULUS10551_0001.zip

-[Unknown]

@ghost
Copy link
Author

ghost commented May 25, 2020

Hm. For me, it does look pretty much like the "PSP" area, but it looks the same in Vulkan and OpenGL for me.

Here's a dump (you can open this and see it render on your device):
ULUS10551_0001.zip

-[Unknown]

how can I open it on my phone using ppsspp?

@unknownbrackets
Copy link
Collaborator

Extract the zip somewhere and browse to that folder, same as an iso. It won't have an icon but it should show up.

-[Unknown]

@ghost
Copy link
Author

ghost commented May 25, 2020

Graphics overlay glitch still showing
Screenshot_20200525-125703

@ghost
Copy link
Author

ghost commented May 25, 2020

No graphics glitch overlay on Snapdragon 430 Adreno 505.
Screenshot_20200525-130501
Maybe this issue can only repro on GLES 2.0 device

@unknownbrackets
Copy link
Collaborator

Oh, the smoke is going through the wall? I didn't notice that before, I thought it was about the bottom part.

The game draws the smoke to a temporary buffer at 0x000cc000. Then around ~267/312 it draws to the screen, using alpha blend src.a + ONE. Depth clamp enabled but doesn't seem involved. But the source image already seems clipped.

It starts drawing that at ~248/312, which is a clear. There it's using depth testing.

So it's relying on depth being copied between two framebuffers, which indeed isn't supported in GLES 2.0...

-[Unknown]

@ghost ghost changed the title [Android] [OpenGL] Ys SEVEN (ULUS10551) graphics glitch overlay on rites of demise stage [Android] [GL2.0] Ys SEVEN (ULUS10551) Smoke going through the wall on "Rites of Demise" stage. May 25, 2020
@Panderner
Copy link
Contributor

IMG_20200525_132525
I'm using Realme C2 and PPSSPP v1.9.3-956-gc8f8d5511 it displays correctly

@hrydgard
Copy link
Owner

I think we can close this, not fixable on ES 2.0 devices..

@Panderner
Copy link
Contributor

I think we can close this, not fixable on ES 2.0 devices..

Any games that requires GLES3 to Render Correctly @hrydgard?

@unknownbrackets
Copy link
Collaborator

Jeanne d'Arc comes to mind, for the same reason (depth copying.) There might be some with blending issues.

-[Unknown]

@Panderner
Copy link
Contributor

Panderner commented May 25, 2020

how about other games than Jeanne d'Arc?

@hrydgard
Copy link
Owner

hrydgard commented May 25, 2020

Saint Seiya, I believe.

At least this game seems to be quite playable even without this effect error.

@ghost ghost changed the title [Android] [GL2.0] Ys SEVEN (ULUS10551) Smoke going through the wall on "Rites of Demise" stage. [Android] [GLES 2] [Depth/Z] Ys SEVEN (ULUS10551) smoke going through the wall Jun 5, 2020
@ghost
Copy link
Author

ghost commented Jun 5, 2020

Just linking other related issues.

#1283 Jeanne D'Arc - Invisible Dialogue Box and Models (GLES2)

#1808 Saint Seiya Omega Missing Character (GLES2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants