Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens flare effect green flash, corrupt FMVs #16075

Closed
4 of 5 tasks
71knight opened this issue Sep 21, 2022 · 12 comments · Fixed by #16081
Closed
4 of 5 tasks

Lens flare effect green flash, corrupt FMVs #16075

71knight opened this issue Sep 21, 2022 · 12 comments · Fixed by #16081
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@71knight
Copy link

71knight commented Sep 21, 2022

Game or games this happens in

Burnout dominator, need for speed shift, maybe more

What area of the game

During full motion videos before racing, also lens flare has green boxes in it briefly.

What happens

Full motion videos have digital artifact errors/ random digital error squares, sometimes almost covering complete screen. Lens flare has momentary green squares in it. Best seen when viewing car model at car selection screen and rotating car. I believe the developer said this was caused by not implementing Z-upload.

What should happen

Videos should play back perfect. Lens flare effect shouldn't have green boxes in it briefly.

GE frame capture

No response

Platform

Android 11

Mobile phone model or graphics card

OnePlus 7t with adreno 640.

PPSSPP version affected

1.13.2 1091

Last working version

Dunno

Graphics backend (3D API)

Vulkan

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try changing graphics settings to determine if one causes the glitch (especially speed hacks or enhancements/replacements.)
  • Include logs or screenshots of issue.
@hrydgard hrydgard changed the title Fixed? lens flare effects corrupts fmvs Lens flare effect green flash, corrupt FMVs Sep 21, 2022
@hrydgard
Copy link
Owner

hrydgard commented Sep 21, 2022

I don't know how the effect is related to FMVs, but who knows (oh, these are actually not full motion video, it's rendered the same way as in-game).

Green flash is known, and I do plan to fix it of course.

@hrydgard hrydgard added this to the v1.14.0 milestone Sep 21, 2022
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Sep 21, 2022
@hrydgard
Copy link
Owner

OK, not only was checking the CLUT usage flag of the framebuffer not reliable (of course, one frame late), but we end up resizing the clut framebuffer immediately after creating for some reason, which loses the just-uploaded z buffer. Fixing that.

@hrydgard
Copy link
Owner

Oops, looks like I broke this again in #16072 . Many moving parts.. Should be an easy fix.

@71knight
Copy link
Author

Sorry for bad news but sunspot is visible through mountains and tunnels.

@hrydgard
Copy link
Owner

Not for me on PC. But I'll take a look on Android. Thanks

@hrydgard hrydgard reopened this Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

Sorry for bad news but sunspot is visible through mountains and tunnels.

What backend?

@71knight
Copy link
Author

71knight commented Sep 23, 2022

Nevermind....the sunspot is fixed along with the lens flare in the latest build. The full motion video is still corrupt in burnout dominator and need for speed shift. The problem appears to be because of live rendered graphics (X and O button, options, etc.) over the full motion video background and the buffers aren't playing nice with each other I guess. I played a full motion video with no graphic overlays and it played perfectly. I even tried another ISO of the same game and it still was broken. Maybe the lens flare and sun fix had something to do with it maybe? Great job on fixing the lens flare and sun occlusion.

@hrydgard
Copy link
Owner

Thanks. I don't understand which FMV is looking corrupt though, can you make a screenshot, or tell me which one and how to get it to play?

@71knight
Copy link
Author

On need for speed shift you can see it when you're selecting different options in the menu before a race.
You should see the background glitch when selecting options at the beginning of the game.

@hrydgard
Copy link
Owner

Alright, that kind of glitch is, while definitely a bug, definitely unrelated to the green lens flare and similar.

NFS Shift does seem to have other issues though. The bloom is horribly ugly although that's an artifact of resoultion, and gets better with "Lower resolution for effects". However, billboards in the game seem to be textured with noise or grass or something, that can't be right.

@71knight
Copy link
Author

71knight commented Sep 24, 2022

I've just watched this game being played on a real PSP on YouTube. From what I can tell all the graphics are correct! I don't notice any problem at all with the billboards they look perfect. The only problems are the aforementioned fmvs backgrounds and I've noticed the nitro effect is a little heavy.... It has a slight stutter at the beginning and at the end and I have all my CPU cores maxed out on my phone and GPU set to 499Mhz (SD 855+). I don't know if that can be optimized or not. Also the lens flare is still green on opengl.

@hrydgard
Copy link
Owner

Now that #16461 is in, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants