Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPSSPP is skipping the first press of a circle button after unpausing the game. #15530

Closed
5 tasks done
Hasster1 opened this issue May 10, 2022 · 9 comments
Closed
5 tasks done
Labels
Input/Controller Input and controller issues
Milestone

Comments

@Hasster1
Copy link
Contributor

Hasster1 commented May 10, 2022

Game or games this happens in

Anything. Even homebrews.

What area of the game / PPSSPP

After pausing and unpausing the game, PPSSPP skips the first press of a circle button.
It seems that config doesn't matter.
The input method doesn't matter as well, because i have tried it on my keyboard and gamepad.

And the worst thing, is that it's even present in stable versions starting from 1.12. It's not present in 1.11.3.

What should happen

The button shouldn't be skipped.

Logs

Do you really need them?

Platform

Windows

Mobile phone model or graphics card

Nvidia GeForce 840m

PPSSPP version affected

Since 1.12. It might've happened somewhere between 1.11.3 and 1.12.

Last working version

1.11.3

Graphics backend (3D API)

Other

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@Hasster1
Copy link
Contributor Author

Hasster1 commented May 10, 2022

You need to move in the menu and then quit the pause menu to trigger the skipping. Basically, you need for an item to be selected on the menu, and then exit the pause menu.

@Hasster1
Copy link
Contributor Author

No wait, it's not really skipping, it's just delaying the press of a button

bandicam.2022-05-10.11-31-00-310.mp4

.

@hrydgard hrydgard added the Input/Controller Input and controller issues label May 10, 2022
@hrydgard hrydgard added this to the v1.13.0 milestone May 10, 2022
@unknownbrackets
Copy link
Collaborator

It'd help if you could test git builds between v1.11.3 and and v1.12. Unfortunately, it seems like the builds are gone, but if you're willing to try with Visual Studio (don't worry, you don't need to be a programmer), see here:
https://github.com/hrydgard/ppsspp/wiki/How-to-bisect-to-find-what-broke-a-game

If you try one version half way between, it'll narrow down the possible causes by half. I know there were changes to the control mapping screen in v1.12.x, but I don't remember any that would've affected keyboard input.

In case compiling isn't an option, another thing that might help to verify is trying an even older version, such as v1.9.3: http://ppsspp.org/downloads_all.html#windows

That might at least confirm if there's something flaky or more complex at play here.

-[Unknown]

@Hasster1
Copy link
Contributor Author

Yes, i would like to help with that. The faster this issue gets fixed, the easier it will be for me to play some patapons. I'll try my best.

@Hasster1
Copy link
Contributor Author

Using git bisect i found out that
v1.11.3-1357-gab4dcebd5
Broke it.

v1.11.3-1353-gc8204a24e
Is the last build where this bug does not happen.

In 1353, the selection is staying after you quit the menu and go back into the menu, while in 1357 it automatically disappears once you leave the menu.

@hrydgard
Copy link
Owner

hrydgard commented May 22, 2022

That means it's

Maybe the view eats a keypress somehow? Should be fixable with a bit of investigation..

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented May 29, 2022

Ah, I see. When a child view switches back to EmuScreen, we're not calling UI::EnableFocusMovement(false);, only when creating a new EmuScreen. My bad.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

I think #15560 fixes this, but I don't know what's going on with any delay, so if you could try that build once it's done (under Checks -> Artifacts) or a build after it's merged, that'd be helpful to confirm this is fixed.

Thanks for narrowing down the range. As you can see, it's extremely helpful to figure out a fix (sometimes it's still hard, but it always helps.)

-[Unknown]

@Hasster1
Copy link
Contributor Author

Yup! It's fixed now!
The delay is probably another small bug or might not be a bug at all, it only happens on the keyboard, and only when you hold the circle button to exit the pause menu - it autopresses the circle button after a second, unlike a gamepad, which does not autopress the circle button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

No branches or pull requests

3 participants