[Windows/Android][Movie/MPEG?][Glitch]Some games appear 3 vertical lines on the movie scean.

[nassau-tk]

What happens?

Some games appear 3 vertical lines on the movie scean.

Example)

• Muso Orochi (Not Include Musou Orochi Sairin & 2 Special)
• EXIT
• EXIT2 (Kangaeru EXIT)

PLease,See attached screenshots.

What should happen?

These movies should draw correctly.

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

PPSSPP Ver.：1.10.3-1234
OS：Windows10（64-bit）Japanese
CPU：Ryzen7 3800X（8-core）
GPU：RADEON RX5700XT
Resolution：2560×1440
RAM：32GB

PPSSPP Ver.：1.10.3-1234
OS：Android 10.0
DeviceName：Samusung Galaxy S20 / SC-51A
CPU：Snapdragon865（Octa-core）
GPU：Adreno 650
Resolution：3200 x 1440 (Max)
RAM：12GB
ROM：128GB
ExternalStrage：microSDXC 512GB

[Muso Orochi]

[EXIT]

[EXIT2]

[Panderner]

Still happens in 1x resolution @nassau-tk?

[nassau-tk]

@Panderner

Oops!!
I forgot to write an usual information.:smile:

1x Resolution is not appear these 3 lines.
It will appear 2x Resolution and more.

[hrydgard]

Yeah, very typical of an issue when a game is not written to expect higher resolution. It draws the video in four separate strips but not quite matching coordinates. We might be able to hack around it, but it'll be ugly.

[unknownbrackets]

At best we might be able to detect this is from a video and blit it directly...

-[Unknown]

[Panderner]

This also affects Fate/unlimited codes.

[Panderner]

and also Kamen Rider games too:

[Panderner]

It seems v1.12.3-776-g1c18c172a making worse for affected games but only affects Direct3D 9 and Direct3D 11.

[hrydgard]

That's #15339 , surprising.

Does the "Lazy texture caching" affect it?

Hm, there was a drawEngineCommon_->DispatchFlush(); lost in FlushImm, might be related? What game is that?

[unknownbrackets]

I moved the flush, DispatchSubmitImm does it now. Shouldn't be lost.

-[Unknown]

[Panderner]

Does the "Lazy texture caching" affect it?

Lazy texture caching had no effect for between v1.12.3-770-gc1b8fb737 and v1.12.3-776-g1c18c172a

What game is that?

Fate: Unlimited Codes and Kamen Rider games (Climax Heroes OOO, Climax Heroes Fourze, and Super Climax Heroes)

[unknownbrackets]

Does it reproduce in a GE frame dump - yes would mean that a frame dump works in 770 but not in 776. If so, that would be very useful.

DispatchSubmitImm() and Execute_End() are the only changes, so it ought to be related to one of those, but I only just moved the flushes around. It already had FLUSHBEFORE...

-[Unknown]

[Panderner]

Here's a GE Dump:
recording.zip

and Screenshot for GE Dump:

[hrydgard]

@unknownbrackets I didn't realize this before, but FLUSHBEFORE seems to be a no-op in FastRunLoop! Doh. Can't believe we never noticed.

FLUSHBEFOREONCHANGE is implemented and works though, otherwise a lot of stuff would be broken.

[hrydgard]

I think in a way it's actually right that we don't implement FLUSHBEFORE in FastRunLoop, don't want any additional check in there that we can live without, and since (except SIGNAL/FINISH) it's always used with EXECUTE, it can just be merged into the execution function. But we should kill the flag entirely then I guess.

Though SIGNAL/FINISH not flushing does seem suspicious, heh. (never mind, those aren't executed on their own)