VFPU: Compute sines and cosines in double precision. #13526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's see if we can do without the special checks in double precision.
hrydgard
force-pushed
the
double-precision-sincos-modulo
branch
from
cbdd9da to
16654d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of #12900, and should keep #2921 working.
This was originally suggested as a solution for #2921 in #6329 , but I had forgotten about that. While sin/cos might be a little slower than sinf/cosf, I don't think it'll actually matter much in reality.
The proper solution is of course to reverse engineer the PSP VFPU's functions.
Come to think of it, what breaks #12900 might be the response to inf/nan values.. But difficult to easily test.
Anyway, for future work in this area, we have to make sure to thorougly test invalid inputs in addition to the exact cardinal directions and so on.