Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full-screen mode on phones with a camera inside the screen (notched) #12261

Closed
allfamebutme opened this issue Aug 20, 2019 · 5 comments
Closed

Full-screen mode on phones with a camera inside the screen (notched) #12261

allfamebutme opened this issue Aug 20, 2019 · 5 comments
Labels
Platform-specific (Android)
Milestone
v1.10.0

Comments

@allfamebutme
Copy link

What happens?

PPSSPP doesn’t work in full screen mode, with the dive mode I get a white strip that cuts the space from the beginning of the camera.
PEQpQmXZtO4

What should happen?

The image will stretch to full screen including the space around the camera. As in other emulators.
с

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Samsung Galaxy A60
Android 9.0
PPSSPP v1.8.0
@Abbanon
Copy link
Contributor

Abbanon commented Aug 20, 2019

Just adding this here:
It was briefly mentioned in #12229 (after the issue was closed) by Henrik, so the issue is known to exist for notched phones it just hasn't been fixed yet.

@allfamebutme allfamebutme changed the title Full-screen mode Galaxy A60 Full-screen mode on phones with a camera inside the screen. Aug 20, 2019
@Florin9doi
Copy link
Contributor

May be fixed by #12264

@hrydgard hrydgard added this to the v1.9.0 milestone Aug 21, 2019
@hrydgard hrydgard changed the title Full-screen mode on phones with a camera inside the screen. Full-screen mode on phones with a camera inside the screen (notched) Aug 21, 2019
@hrydgard hrydgard mentioned this issue Aug 23, 2019
Closed
@hrydgard hrydgard modified the milestones: v1.9.0, v1.10.0 Aug 23, 2019
@Halo-Michael
Copy link
Contributor

And please add FullScreen button for iOS

@hrydgard
Copy link
Owner

See #12779 .

unknownbrackets added a commit that referenced this issue Mar 31, 2020
@unknownbrackets
Merge pull request #12779 from hrydgard/notch-support
3965341 
Support drawing around notches on Android displays. Fixes #12261
@Panderner
Copy link
Contributor

And how about iPhone X, XS, XR and 11 Devices? it has notches
IMG_20200331_094428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform-specific (Android)
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
6 participants
@hrydgard @Florin9doi @Abbanon @Panderner @Halo-Michael @allfamebutme