[Vulkan] 魔法少女リリカルなのはA's Portable - Gears of Destiny: Graphical glitch

[Leopard20]

The characters' pictures during dialogs is not displaying correctly.
Vulkan:

OGL:

recording.ppdmp.zip

Device: Mi 5s Plus, Android 8.0

[hrydgard]

Pretty likely to be the same old alpha test issue we've seen on Adreno 500 drivers...

[Leopard20]

Ah...again?!

[unknownbrackets]

Draw 1281/1282, it draws a box that contains the face, using:

• Stencil test ALWAYS REPLACE ff
• Alpha test: a > 2 (means discard)
• Depth test off, but depth write enabled.

This definitely activates the driver bug that the Adreno 5xx has. Our workaround doesn't activate because depth write is enabled (despite depth test being off.)

I suspect it would workaround it to add more to the check:

id.SetBit(FS_BIT_NO_DEPTH_CANNOT_DISCARD_STENCIL, !IsStencilTestOutputDisabled() && !gstate.isDepthWriteEnabled());

Replace with:

id.SetBit(FS_BIT_NO_DEPTH_CANNOT_DISCARD_STENCIL, !IsStencilTestOutputDisabled() && (!gstate.isDepthTestEnabled() || !gstate.isDepthWriteEnabled()));

Not sure if this would have negative impacts in other games.

-[Unknown]

[hrydgard]

Hm, that feels like it should be safe-ish because with the depth test disabled, depth write does nothing.

[Panderner]

This issue does not occur for POCO M3, Android 10 in Vulkan:

[ss8688]

I have a same problem on a Mail-G52 GPU

[Panderner]

It does not occur for my POCO M3 using Vulkan in latest build.

[unknownbrackets]

Is this working now?

-[Unknown]

[unknownbrackets]

Noted as not working in #13599.

-[Unknown]

[ghost]

I can't reproduce this issue on my Redmi Note 9 Mali GPU Vulkan

[Panderner]

I can't reproduce this issue on my Redmi Note 9 Mali GPU Vulkan

Hmm @Gamemulatorer that screenshot lied.

[ss8688]

@Gamemulatorer @Panderner It do appears on my honor 9x with mail g52 .Same as Leopard20's Mi 5s
But not on my redmi k40 with Snapdragon 870
You are using a different device,I think

[ss8688]

It just reproduces on certain devices
I heard that it can be reproduced on HUAWEI mate 30. but don't kown if it is true.
Because I don't have one.

[unknownbrackets]

Right, this is a driver issue. I'm not sure specifically what devices are affected but I think it is only:

• Adreno 5xx GPUs (not Adreno 6xx or newer), AND if they have an older driver (typically, lower than Android 10, but varies by device manufacturer.)
• Mali devices (not sure which), probably also only older than certain drivers but not sure.

The devices mentioned:

• Honor 9x: Mali-G52, Android 10 (affected)
• Huawei Mate 30: Mali-G76, Android ver unknown but >= 10 (affected)
• Redmi Note 9: Mali-G52, Android ver unknown but >= 10 (affected)
• Mi 5s Plus: Adreno 530, Android 8 (affected)
• Redmi K40: Adreno 650 (unaffected)
• Poco M3: Adreno 610 (unaffected)

So on the Mali front, this probably affects all of Bifrost. It'd be interesting to know if any phone with the below SoC has the issue (these are all Valhall, like Adreno 5xx -> 6xx):

• Mali-G57 (Kirin 820, Dimensity 8xx)
• Mali-G68 (not sure)
• Mali-G77 (Kirin 985, Dimensity 1000, Exynos 990)
• Mali-G78 (Kirin 9000, Exynos 1080, Exynos 2100)

If we can narrow down the range we at least would know for sure what devices are and are not affected and might be able to get some info from Mali.

-[Unknown]

[ss8688]

@unknownbrackets

I can't reproduce this issue on my Redmi Note 9 Mali GPU Vulkan

As he says
Redmi note 9 is not affected

[unknownbrackets]

Well, yes, but it sounds like it might be a mistake or typo because the provided screenshot does show the issue as Panderner and Leopard20 noted.

If it's indeed not affected, that could mean a driver update fixed it which would be good and might mean a driver update would fix the others if available. In that case, Mali might know more about the details of the glitch and if a workaround is possible. But like I said, I suspect it was a mistake and that device is also affected.

-[Unknown]

[ghost]

@unknownbrackets

I can't reproduce this issue on my Redmi Note 9 Mali GPU Vulkan

As he says
Redmi note 9 is not affected

Sorry I was wrong there 😅
But to fix this issue just added this game to PixelDepthRounding and the issue is solve at least for me :3

PROOF

Screenrecorder-2021-10-13-17-20-17-565.mp4

@ss8688 feedback please.

[hrydgard]

Probably means that the driver over-optimizes something, and PixelDepthRounding prevents it from doing so as a side effect - and would not be needed on other GPUs, and is supposed to have some performance cost.

At this point maybe we need to add a PixelDepthRoundingIfMali to avoid performance loss...

[ghost]

This can be fixed now via c5a10a5 on MALI GPU only I don't know about Adreno.

[unknownbrackets]

I assume the latest change triggers this since depth test is off. So I'm going to close.

Please comment if it's not actually fixed on your device with more detail about your device and its GPU and driver version.

-[Unknown]

[ghost]

This issue can still reproduce on adreno gpu in vulkan.

Record_2022-09-16-01-10-13.mp4

[ghost]

PixelDepthRounding can fix this issue on adreno gpu in vulkan.

[unknownbrackets]

I wonder if this just means there's something wrong with the workaround in recent versions. Was it working in older git builds (around when it was confirmed before)? If yes, it must've broken at some time.

PixelDepthRounding is a bit expensive and can reduce quality (like forcing 1x PSP render resolution), so it may not be the ideal fix.

-[Unknown]

[hrydgard]

Hm, we only activate the workaround on certain driver versions on Adreno:

https://github.com/hrydgard/ppsspp/blob/master/Common/GPU/Vulkan/thin3d_vulkan.cpp#L807

Maybe the range is simply too narrow. Can you check your GPU and driver version in Settings/Tools/System Information?

[unknownbrackets]

It was definitely fixed on version 0x80180000 with an Adreno 530, but maybe driver versions are not so linear. And it was not seen on Adreno 620 or 630 devices.

-[Unknown]

[ghost]

Hm, we only activate the workaround on certain driver versions on Adreno:

https://github.com/hrydgard/ppsspp/blob/master/Common/GPU/Vulkan/thin3d_vulkan.cpp#L807

Maybe the range is simply too narrow. Can you check your GPU and driver version in Settings/Tools/System Information?

[hrydgard]

Seems on Adreno we were still using the old check, refined it for the Mali bug. Testing on the dump, only the Mali check catches it.

So decided to finally merge these two bug workarounds, and also remove the compat flag and just activate it universally when we detect stencil without depth.

Should work once #16043 is merged.

[hrydgard]

Please check if that fixed it.

[ghost]

Yes, this was fix via 4045de8