Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling SDL within PPSSPP on macOS #11830

Closed
vit9696 opened this issue Feb 23, 2019 · 3 comments
Closed

Bundling SDL within PPSSPP on macOS #11830

vit9696 opened this issue Feb 23, 2019 · 3 comments

Comments

@vit9696
Copy link
Contributor

vit9696 commented Feb 23, 2019

@hrydgard, last time I grumbled about it, @angelXwind said it was your desire not to bundle libSDL within PPSSPP builds on macOS. I think there was some misunderstanding from the sides here, and request it to be changed.

For instance, I do not use HomeBrew, and constantly having to fix provided binaries to locate the right lib (/usr/local/lib → /opt/local/lib) makes me unhappy. Putting aside having to install something like libSDL at all. I believe PPSSPP should launch on stock macOS without this mess.

Something as simple as the script below puts libSDL binary inside app Frameworks and makes the resulting build portable. I admit that Qt framework, which you also use, does exactly the same thing via macdeployqt, which is slightly more advanced.

SDL=$(otool -L PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL | grep -Eo /.+libSDL.+dylib)
if [ "$SDL" != "" ]; then
  if [ -f "$SDL" ]; then
    SDLNAME=$(basename "$SDL")
    mkdir -p PPSSPPSDL.app/Contents/Frameworks || exit 1
    cp -r "$SDL" PPSSPPSDL.app/Contents/Frameworks || exit 1
    install_name_tool -change "$SDL" "@executable_path/../Frameworks/$SDLNAME" PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL || exit 1
  fi
fi

I think we should include its invocation in cmake, and given that you use Travis, upload macOS builds to https://buildbot.orphis.net/ppsspp/index.php and/or some other place. I kind of hope to see release builds instead of snapshots too.

@hrydgard
Copy link
Owner

Yeah, I think I agree with this. Pull requests accepted :)

The buildbot situation needs improvement for sure. Will see what I can do...

@vit9696
Copy link
Contributor Author

vit9696 commented Feb 23, 2019

I guess everyone here likes pull requests way more than I do. Submitted a patch :)
Let it go through travis before merging. It worked fine for me with macports, but I did not have a chance to test it with homebrew. Also, is it too late for 1.8.0?

@hrydgard
Copy link
Owner

Definitely not too late, especially since we don't yet do official releases for Mac (though yes, we should).

hrydgard added a commit that referenced this issue Feb 23, 2019
Bundle libSDL inside app on macOS, fixes #11830
@hrydgard hrydgard modified the milestones: v1.9.0, v1.8.0 Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants