Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cardboard stereo rendering #11668

Closed
hrydgard opened this issue Dec 14, 2018 · 25 comments
Closed

Remove Cardboard stereo rendering #11668

hrydgard opened this issue Dec 14, 2018 · 25 comments
Milestone

Comments

@hrydgard
Copy link
Owner

Is anyone actually using this, or is it just something somebody implemented for fun?

I don't really see much point to be honest, especially since we're not doing real stereo rendering anyway...

@hrydgard hrydgard added this to the Future milestone Dec 14, 2018
@marosis
Copy link

marosis commented Dec 14, 2018

No i don't.

@JimsAlliance
Copy link

Where can I enable this?

@unknownbrackets
Copy link
Collaborator

I wouldn't miss it.

It's under graphics settings, and causes a "silver screen" effect where there's a projected 2d screen where the game is rendered.

-[Unknown]

@JimsAlliance
Copy link

JimsAlliance commented Dec 14, 2018

It's under graphics settings, and causes a "silver screen" effect where there's a projected 2d screen where the game is rendered.

That is the best way to support it without an actual VR mode. I don't game much on mobile because my gamepads are incompatible, but I would definitely use it otherwise. I wouldn't remove it as I'm sure there are VR gamers out there who use it regularly.

@mygizli04
Copy link
Contributor

I mean this is great for people who want to experience PSP games in VR but don't wanna spend too much money... And no reason for removing it right?

@weihuoya
Copy link
Contributor

I think play psp game with this "fake" VR mode is a bad experience. these settings are not useful in my opinion.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Dec 14, 2018

Playing with "real VR" would be even worse as PSP games were not designed with VR in mind, that feature wasn't either.

The point was to use tiny screen placed in front of the eyes to simulate big screen. For such use separate image for each eye is pretty neat doesn't matter if they are exactly same, but if it's super rare it could be degraded to ini-only setting as the clutter in UI it causes is pretty serious, even people who could use it regularly, shouldn't have need to switch it's settings all the time.

@hrydgard
Copy link
Owner Author

Unlike some of the other settings I want to remove at least this one doesn't cause compatibility problems, so it's not as big of a win to remove it, just getting rid of a little bit of code and UI clutter.

I'll leave this issue around for comments for a while longer before making a decision.

@ghost
Copy link

ghost commented Dec 15, 2018

@hrydgard Sir what the use of "Rewind Snapshot Frequency (mem hog) in system?

*Sorry for asking Im just curious

@unknownbrackets
Copy link
Collaborator

It basically makes PPSSPP create an internal save state every so often (e.g. every second or every minute.) Then you can press a button to rewind backwards. Let's say you were platforming and you fell off a cliff - you press rewind and try the cliff again.

-[Unknown]

@ghost
Copy link

ghost commented Dec 15, 2018

@unknownbrackets thanks for info about that 👍

@ghost
Copy link

ghost commented Dec 17, 2018

The hack setting "Lower Resolution For Effects (Reduce Artifacts)" should also be removed I didn't use that and no performance improvement :/ (imo)

@hrydgard
Copy link
Owner Author

@Emulatorer That hack setting fixes bloom effect in a few games (they use bilinear filter to blur, which doesn't work if the resolution is too high).

Although, it could be argued that we should just force it on where needed using compat.ini.

@hrydgard
Copy link
Owner Author

hrydgard commented Jun 26, 2019

Got another confused email where a user accidentally enabled it.

I think this feature does more harm than good at this point, and I am going to kill it off.

@hrydgard hrydgard modified the milestones: Future, v1.9.0 Jun 26, 2019
@hrydgard hrydgard changed the title Remove Cardboard stereo rendering? Remove Cardboard stereo rendering Jun 27, 2019
hrydgard added a commit that referenced this issue Jul 1, 2019
hrydgard added a commit that referenced this issue Oct 25, 2019
hrydgard added a commit that referenced this issue Oct 25, 2019
@94svtbird
Copy link

I just spend about 15 minutes trying to find the cardboard enable setting only to stumble upon this thread. Thanks for all the hard work everyone. I use PPSSPP with Legacy Doom and Gear VR. Its ok I can just use the last version. I feel like the code could have just been left in there. But as is life, the dumb ones ruin it for the rest of us.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Nov 8, 2019

@94svtbird just use the latest version(not last release), this was re-added two weeks ago.

@Jamrrad
Copy link

Jamrrad commented Jan 21, 2020

Uhm, where did the cardboard vr setting go? That's the only reason I support this emulator. I play with a pocket vr clipped to a hat visor. Why the hell would anyone want to play this emulator without this feature?!!!

@unknownbrackets
Copy link
Collaborator

Update to the latest git build, it has returned. See the comment right above yours.

-[Unknown]

@Jamrrad
Copy link

Jamrrad commented Jan 21, 2020

Ya, thanks for that and huge thanks to everyone who works on PPSSPP. Will this be coming back to the official play store build though? 🥺

@hrydgard
Copy link
Owner Author

Yes, what's in the git builds is the progress towards the next release.

@Jamrrad
Copy link

Jamrrad commented Jan 21, 2020

Cool 😎total newb
...Here's why the vr option is a must for me... www.virtualvizor.com .... pairing a visor headset with a steel series stratus on PPSSPP is still one of the best pocket VR experiences out there.

@hrydgard
Copy link
Owner Author

haha yeah that's like a cardboard without the cardboard, cool

@Jamrrad
Copy link

Jamrrad commented Jan 21, 2020

Heck ya, I never leave home without a pocket visor VR. Well atleast until the "Mojo Lense" is commercialized or something. I'll still likely use it even then though. I have a different custom made pocket visor VR that I use primarily too because it works with curved hat visors as well as flat visors. It's being tailored for the 3D printing community and I'd be happy to link it to y'all when its done!

@hrydgard
Copy link
Owner Author

I got a 3D printer, but I guess I'd still need to get some lenses, those won't print well even with transparent PETG :D

@Jamrrad
Copy link

Jamrrad commented Jan 21, 2020

Ya lol, a CNC router can create lenses though! Lenses are pretty cheap too. The pocket headset I'm creating for 3d printing is capable of interchangeable lenses. I'm coupling the creation as a GearVR mod, so the lenses from GearVR can be used and the GearVR circuitry is then minimized to fit into a pocket as well! This works really well as a wireless display for windows through the gearvr virtual desktop app. Other headsets don't allow a person to see their hands for typing and multitasking. The open peripheral view on this type of headset and its portability is extremely useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants