Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6.2 Play Store detected crashes #11116

Closed
hrydgard opened this issue Jun 1, 2018 · 7 comments · Fixed by #11121
Closed

1.6.2 Play Store detected crashes #11116

hrydgard opened this issue Jun 1, 2018 · 7 comments · Fixed by #11121
Milestone
v1.6.3

Comments

@hrydgard
Copy link
Owner

hrydgard commented Jun 1, 2018 •
edited
Loading 

 #00  pc 000000000048340e  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN14ManagedTexture10GetTextureEv+5)
  #01  pc 00000000004bb857  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9UIContext5BeginEv+46)
  #02  pc 000000000042c04f  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9EmuScreen8renderUIEv+42)
  #03  pc 000000000042be23  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN9EmuScreen6renderEv+130)
  #04  pc 00000000004bb065  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZN13ScreenManager6renderEv+84)
  #05  pc 00000000004251cb  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_Z12NativeRenderP15GraphicsContext+794)
  #06  pc 000000000042050f  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_Z20UpdateRunLoopAndroidP7_JNIEnv+22)
  #07  pc 0000000000421855  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so
  #08  pc 00000000002b72a5  /mnt/asec/org.ppsspp.ppsspp-2/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)
  #09  pc 0000000000016f23  /system/lib/libc.so (_ZL15__pthread_startPv+30)
  #10  pc 0000000000014f43  /system/lib/libc.so (__start_thread+6

Thought we had fixed this one, apparently not.

#00  pc 000000000007f392  /system/vendor/lib/hw/vulkan.msm8937.so (_ZN16A5xDescriptorSet24HwUpdateWriteDescriptorsEPK22QglDescriptorWriteData+273)
  #01  pc 0000000000044e07  /system/vendor/lib/hw/vulkan.msm8937.so (_ZN11qglinternal22vkUpdateDescriptorSetsEP10VkDevice_TjPK20VkWriteDescriptorSetjPK19VkCopyDescriptorSet+198)
  #02  pc 00000000004b0649  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw9VKContext24GetOrCreateDescriptorSetEy+424)
  #03  pc 00000000004b1439  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN4Draw9VKContext6DrawUPEPKvi+224)
  #04  pc 000000000049588d  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN10DrawBuffer5FlushEb+212)
  #05  pc 00000000004bbacb  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN9UIContext5FlushEv+18)
  #06  pc 000000000043cf03  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z18DrawGameBackgroundR9UIContextRKNSt6__ndk112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEE+270)
  #07  pc 00000000004bcd85  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN8UIScreen6renderEv+88)
  #08  pc 00000000004bb065  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZN13ScreenManager6renderEv+84)
  #09  pc 00000000004251cb  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_Z12NativeRenderP15GraphicsContext+794)
  #10  pc 00000000004212c5  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (Java_org_ppsspp_ppsspp_NativeActivity_runEGLRenderLoop+320)
  #11  pc 0000000000018a75  /data/app/org.ppsspp.ppsspp-1/oat/arm/base.odex

Previously we would crash if we tried setting a null texture, but it does not seem to be a good thing for drivers either, heh. Should definitely fix this before 1.6.3, which I hope will be the final in the series...

 #00  pc 00000000004a7aac  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (Draw::OpenGLContext::CreateGraphicsPipeline(Draw::PipelineDesc const&)+119)
  #01  pc 00000000004249ef  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (NativeInitGraphics(GraphicsContext*)+1022)
  #02  pc 0000000000421821  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so
  #03  pc 00000000002b72a5  /data/app/org.ppsspp.ppsspp-1/lib/arm/libppsspp_jni.so (_ZNSt6__ndk114__thread_proxyINS_5tupleIJNS_10unique_ptrINS_15__thread_structENS_14default_deleteIS3_EEEEPFvvEEEEEEPvSA_+24)
  #04  pc 00000000000134a3  /system/lib/libc.so (__pthread_start(void*)+30)
  #05  pc 00000000000114a7  /system/lib/libc.so (__start_thread+6)

Here's an apparently old one that started bubbling up the charts when I fixed the most common other crashes...
@hrydgard hrydgard added this to the v1.6.3 milestone Jun 1, 2018
@hrydgard
Copy link
Owner Author

hrydgard commented Jun 1, 2018

Also on some HW like the GPD XD we still have GL error-related crashes on task switching: #11063 (comment)

@hrydgard hrydgard mentioned this issue Jun 1, 2018
Merged
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Jun 2, 2018
@unknownbrackets
UI: Reinit UI texture during game when used.
18bfff5 
Otherwise we may try to use it when it doesn't exist.  This should only
happen on graphics restart.

Potentially related to first crash in hrydgard#11116.
@unknownbrackets unknownbrackets mentioned this issue Jun 2, 2018
Merged
@Leopard20
Copy link
Contributor

@hrydgard
Don't forget to add Prince of Persia Revelations and Rival swords black/yellow screen fixes to v1.6.3 changelog! I think a lot of people were looking forward to this.

@hrydgard
Copy link
Owner Author

hrydgard commented Jun 3, 2018 •
edited
Loading

Yeah, I will. I'll be pushing 1.6.3 on Monday or Tuesday, more likely Tuesday since I want to make an attempt on the GPD XD issue. Hopefully the last in the series...

@Leopard20
Copy link
Contributor

It was just a reminder. No need to rush.
I hope they'll be fixed too. I've been looking forward to some of the pending pull requests!

@Leopard20
Copy link
Contributor

@hrydgard
I noticed something strange. The latest version on Google Play is v1.5.4 (at least for me). But it also says: Updated on June 5. Any idea what's wrong?

@hrydgard
Copy link
Owner Author

hrydgard commented Jun 5, 2018

The latest version will be 1.6.3 for you when I roll it out to everyone tomorrow. Currently at 20%.

@Leopard20
Copy link
Contributor

@hrydgard
Oh. Sorry. I don't know all the steps involved in Google Play releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.3
Development

Successfully merging a pull request may close this issue.

UI: Reinit UI texture during game when used unknownbrackets/ppsspp
2 participants
@hrydgard @Leopard20