Downloader: Join threads in CancelAll

hrydgard · Jun 28, 2020 · bd8083f · bd8083f
1 parent 1a8084c
commit bd8083f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ext/native/net/http_client.cpp b/ext/native/net/http_client.cpp
@@ -446,6 +446,9 @@ void Download::Start() {
 }
 
 void Download::Join() {
+	if (joined_) {
+		ELOG("Already joined thread!");
+	}
 	thread_.join();
 	joined_ = true;
 }
@@ -585,6 +588,9 @@ void Downloader::CancelAll() {
 	for (size_t i = 0; i < downloads_.size(); i++) {
 		downloads_[i]->Cancel();
 	}
+	for (size_t i = 0; i < downloads_.size(); i++) {
+		downloads_[i]->Join();
+	}
 	downloads_.clear();
 }