Skip to content

Commit

Permalink
Don't use glTexStorage2D, see issue #6075
Browse files Browse the repository at this point in the history 
Probably didn't help much anyway.
  • Loading branch information
@hrydgard
hrydgard committed Jun 8, 2014
1 parent 77c85bc commit 9c799b7
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion GPU/GLES/TextureCache.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1383,7 +1383,10 @@ void TextureCache::SetTexture(bool force) {
if (entry->addr > 0x05000000 && entry->addr < 0x08800000)
scaleFactor = 1;

if (gl_extensions.GLES3 && maxLevel > 0) {
// Disabled this due to issue #6075: https://github.com/hrydgard/ppsspp/issues/6075
// This breaks Dangan Ronpa 2 with mipmapping enabled. Why? No idea, it shouldn't.
// glTexStorage2D probably has few benefits for us anyway.
if (false && gl_extensions.GLES3 && maxLevel > 0) {
// glTexStorage2D requires the use of sized formats.
GLenum storageFmt = GL_RGBA8;
switch (dstFmt) {
Expand Down

3 comments on commit 9c799b7

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented on 9c799b7 Jun 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to change to
if (gl_extensions.GLES3 && maxLevel > 0 && !g_Config.bMipMap) {
?

@hrydgard
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glTexStorage2D is supposed to just be a minor speedup, but I haven't seen any difference. So just turning it off.

@sum2012
Copy link
Collaborator

@sum2012 sum2012 commented on 9c799b7 Jun 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

Please sign in to comment.