Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpeg4 on Linux. Update Linux x86_64 libs and headers, rebuild x86 with mpeg4 support. #45

Merged
merged 3 commits into from
Aug 16, 2017

Conversation

hcorion
Copy link
Contributor

@hcorion hcorion commented Aug 10, 2017

These were generated on Arch Linux.
I added the mpeg4 support because we were having some troubles with RPCS3 trying to use mpeg4.

$ gcc --version
gcc (GCC) 7.1.1 20170630
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ pacman -Ss glibc           
core/glibc 2.25-7 (base) [installed]
    GNU C Library

@hcorion hcorion changed the title Update Linux x86_64 libs and headers Add mpeg4 on Linux. Update Linux x86_64 libs and headers, rebuild x85 with mpeg4 support. Aug 10, 2017
@hcorion hcorion changed the title Add mpeg4 on Linux. Update Linux x86_64 libs and headers, rebuild x85 with mpeg4 support. Add mpeg4 on Linux. Update Linux x86_64 libs and headers, rebuild x86 with mpeg4 support. Aug 10, 2017
Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I wonder if we want/need to add mpeg4 on other platforms, most notably Windows and Android...

-[Unknown]

@hcorion
Copy link
Contributor Author

hcorion commented Aug 16, 2017

It's already enabled on Windows, not sure about other platforms

@unknownbrackets
Copy link
Collaborator

Ah, indeed. Looks like someone started to refactor but didn't update all the scripts:
https://github.com/hrydgard/ppsspp-ffmpeg/blob/master/shared_options.sh#L26

The list used by other platforms is probably more correct for PPSSPP:
https://github.com/hrydgard/ppsspp-ffmpeg/blob/master/android_x86.sh#L40-L45

So it seems Linux and Mac are the wrong ones, but not sure we really need mjpeg or h263. Does RPCS3 use any of the other decoders?

-[Unknown]

@unknownbrackets unknownbrackets merged commit 7b7ae7b into hrydgard:master Aug 16, 2017
@hrydgard
Copy link
Owner

Oh, sorry for the delay, I forgot about this pull request.

Thanks unknown. I don't think it matters much if we have mjpeg or h263 unnecessarily, they're probably either small or sharing at least some code with h264..

@hcorion
Copy link
Contributor Author

hcorion commented Aug 17, 2017

Also, just FYI, If you try to link these libs with the ld provided in binutils 2.26 (the one currently used in Ubuntu Trusty), it will fail. You need to use a newer binutils for that.
This is due to a bug, mentioned here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248

@unknownbrackets
Copy link
Collaborator

Hmm, not sure - that might be a problem. I think our travis builds are on Trusty...

-[Unknown]

@hcorion
Copy link
Contributor Author

hcorion commented Aug 19, 2017

Yes, I had to hack the RPCS3 travis build by using a non-official binutils version, see: RPCS3/rpcs3@514a983

@hcorion
Copy link
Contributor Author

hcorion commented Aug 19, 2017

The executables still work, but it's a nasty potential security problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants