-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mpeg4 on Linux. Update Linux x86_64 libs and headers, rebuild x86 with mpeg4 support. #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I wonder if we want/need to add mpeg4 on other platforms, most notably Windows and Android...
-[Unknown]
It's already enabled on Windows, not sure about other platforms |
Ah, indeed. Looks like someone started to refactor but didn't update all the scripts: The list used by other platforms is probably more correct for PPSSPP: So it seems Linux and Mac are the wrong ones, but not sure we really need mjpeg or h263. Does RPCS3 use any of the other decoders? -[Unknown] |
Oh, sorry for the delay, I forgot about this pull request. Thanks unknown. I don't think it matters much if we have mjpeg or h263 unnecessarily, they're probably either small or sharing at least some code with h264.. |
Also, just FYI, If you try to link these libs with the ld provided in binutils 2.26 (the one currently used in Ubuntu Trusty), it will fail. You need to use a newer binutils for that. |
Hmm, not sure - that might be a problem. I think our travis builds are on Trusty... -[Unknown] |
Yes, I had to hack the RPCS3 travis build by using a non-official binutils version, see: RPCS3/rpcs3@514a983 |
The executables still work, but it's a nasty potential security problem. |
These were generated on Arch Linux.
I added the mpeg4 support because we were having some troubles with RPCS3 trying to use mpeg4.