docs: Add comments and type annotations for sorting comparators #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added type annotation `cmp.Comparator` for sorting.comparators
|
thank you. |
williamboman
added a commit
to williamboman/nvim-cmp
that referenced
this pull request
Oct 26, 2023
…indow * upstream/main: fix: remove usages from vim.lsp.util.parse_snippet (hrsh7th#1734) ci: fix broken tests (hrsh7th#1729) Format with stylua docs: Add comments and type annotations for sorting comparators (hrsh7th#1687) fix(ghost_text): `ephemeral` causes a false positive of no inline support (hrsh7th#1645) perf(core): simplify and improve `find_line_suffix()` (hrsh7th#1675) Format with stylua feat: add toggle_doc functionality (hrsh7th#1647) add context check for invalid detection implement is_invalid detection perf: fix `nvim_replace_termcodes` being called on every `CursorMoved` (hrsh7th#1650) improve pattern handling Format with stylua fix confirm resolve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added type annotation
cmp.Comparatorfor sorting.comparators