-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rockspec #1051
feat: add rockspec #1051
Conversation
nvim-cmp-scm-1.rockspec
Outdated
} | ||
|
||
source = { | ||
url = "http://github.com/hrsh7th/nvim-cmp/archive/v" .. _MODREV .. ".zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution.
This will be http://github.com/hrsh7th/nvim-cmp/archive/vscm.zip
.
Is it expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scm stands for source control management
. development versions tend to be called like that. If you want to properly release a version e.g. "0.1" then you need to edit the rockspec to change the first line to local _MODREV, _SPECREV = "scm", "-1"
. You dont have to version such a file (even though that could be handy) but what is useful is to upload it to luarocks.org so that other projects can reference it.
so that other plugins can mark nvim-cmp as a dependency Some justification there https://teto.github.io/posts/2022-06-22-neovim-plugin-luarocks-2.html
I'd create the release |
I'll fix the version that contained the URL. merging. |
thank you ! I was on holiday sry. |
hi, I was trying to update my linux distribution to use this package but I can't find the rockspec on main or on v0.0.1. Did I miss anything ? |
Oh... Sorry. It has indeed disappeared before I knew it. I must have made a mistake. I will restore it. |
@teto I've restore the rockspec files. |
so that other plugins can mark nvim-cmp as a dependency
Some justification there https://teto.github.io/posts/2022-06-22-neovim-plugin-luarocks-2.html