Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rockspec #1051

Merged
merged 1 commit into from
Aug 20, 2022
Merged

feat: add rockspec #1051

merged 1 commit into from
Aug 20, 2022

Conversation

teto
Copy link
Contributor

@teto teto commented Jun 27, 2022

so that other plugins can mark nvim-cmp as a dependency

Some justification there https://teto.github.io/posts/2022-06-22-neovim-plugin-luarocks-2.html

}

source = {
url = "http://github.com/hrsh7th/nvim-cmp/archive/v" .. _MODREV .. ".zip",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution.

This will be http://github.com/hrsh7th/nvim-cmp/archive/vscm.zip.
Is it expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scm stands for source control management. development versions tend to be called like that. If you want to properly release a version e.g. "0.1" then you need to edit the rockspec to change the first line to local _MODREV, _SPECREV = "scm", "-1". You dont have to version such a file (even though that could be handy) but what is useful is to upload it to luarocks.org so that other projects can reference it.

so that other plugins can mark nvim-cmp as a dependency

Some justification there https://teto.github.io/posts/2022-06-22-neovim-plugin-luarocks-2.html
@hrsh7th
Copy link
Owner

hrsh7th commented Aug 14, 2022

I'd create the release v0.0.1. Could you specify the actual zip URL?

@hrsh7th
Copy link
Owner

hrsh7th commented Aug 20, 2022

I'll fix the version that contained the URL. merging.

@hrsh7th hrsh7th merged commit 274a3f9 into hrsh7th:main Aug 20, 2022
@teto teto deleted the rockspec branch August 20, 2022 19:02
@teto
Copy link
Contributor Author

teto commented Aug 22, 2022

thank you ! I was on holiday sry.

@teto
Copy link
Contributor Author

teto commented Sep 5, 2022

hi, I was trying to update my linux distribution to use this package but I can't find the rockspec on main or on v0.0.1. Did I miss anything ? git log -- nvim-cmp-scm-1.rockspec doesnt find anything, was there a rebase of some kind ?

@hrsh7th
Copy link
Owner

hrsh7th commented Sep 6, 2022

Oh... Sorry. It has indeed disappeared before I knew it.

I must have made a mistake. I will restore it.

@hrsh7th
Copy link
Owner

hrsh7th commented Sep 6, 2022

@teto I've restore the rockspec files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants