Code

Add the debug mode#142

Code

Merged

antocuni merged 70 commits intomasterhpyproject/hpy:masterfrom antocuni/debug-modehpyproject/hpy:antocuni/debug-modeCopy head branch name to clipboardFeb 4, 2021

+2,587-442

Commits

Commits on Dec 15, 2020

• temporarily comment this out, see issue #140

  antocuni

  committed
  1cd887a

  Copy full SHA for 1cd887a

• Add two fields to HPyContext:

  Show description for 4551d10
  antocuni

  committed
  4551d10

  Copy full SHA for 4551d10

• WIP: introduce hpy.debug.

  Show description for 97803d8
  antocuni

  committed
  97803d8

  Copy full SHA for 97803d8

• refactor _ctx.c to use a statically allocated debug_ctx/debug_info, and to intiialize them at module init time

  antocuni

  committed
  2d868ec

  Copy full SHA for 2d868ec

Commits on Dec 16, 2020

• rename global_ctx into g_universal_ctx: I think it's clearer and we will need to distinguish it from g_debug_ctx later

  antocuni

  committed
  c379b34

  Copy full SHA for c379b34

• WIP 1

  antocuni

  committed
  c3c97c1

  Copy full SHA for c3c97c1

• WIP: introduce a new function hpy.universal.load, which will be used to load modules in debug mode

  antocuni

  committed
  0f939ee

  Copy full SHA for 0f939ee

• kill hpy.universal.load_from_spec: rename it into load(), which takes the name and the path as two normal arguments

  antocuni

  committed
  3141873

  Copy full SHA for 3141873

• Partially undo some of the changes introduced by PR #124 (merged by commit 22a05e8)

  Show description for ba33924
  antocuni

  committed
  ba33924

  Copy full SHA for ba33924

• Implement hpy.universal.load(..., debug=True)

  Show description for 18c4a34
  antocuni

  committed
  18c4a34

  Copy full SHA for 18c4a34

• blindly try to fix the tests

  antocuni

  committed
  85ae3ae

  Copy full SHA for 85ae3ae

• try again

  antocuni

  committed
  dd0c650

  Copy full SHA for dd0c650

Commits on Dec 17, 2020

• Completely change the approach and greatly simplify the code.

  Show description for fa5849f
  antocuni

  committed
  fa5849f

  Copy full SHA for fa5849f

• some compilers complain that I can't use a static const in a static initializer. Try with a define

  antocuni

  committed
  d8a1736

  Copy full SHA for d8a1736

• test_FatalError needs __file__: make sure it is available also when we load universal modules

  antocuni

  committed
  d40d85d

  Copy full SHA for d40d85d

• distutils uses -DNDEBUG by default: make sure to re-enable asserts when we run make debug; this also catches a type error in an assert which was compiled away

  antocuni

  committed
  2caaa3b

  Copy full SHA for 2caaa3b

Commits on Dec 21, 2020

• Merge branch 'master' into antocuni/debug-mode

  hodgestar

  committed
  cd0f0ea

  Copy full SHA for cd0f0ea

• Move .load_module to test_importing and add some protection against modules ending up in sys.modules.

  hodgestar

  committed
  d6fcfe7

  Copy full SHA for d6fcfe7

Commits on Dec 30, 2020

• autogenerate the debug wrappers and the definition of the debug ctx. Currently the wrappers simply forwards everything to the original ctx

  antocuni

  committed
  b6fffec

  Copy full SHA for b6fffec

Commits on Dec 31, 2020

• ignore these two files

  antocuni

  committed
  099bedb

  Copy full SHA for 099bedb

• Introduce a _debug module which will contain the python-level interface to the debug mode.

  Show description for ee51500
  antocuni

  committed
  ee51500

  Copy full SHA for ee51500

• introduce DHPy, which is the debug mode's version of a handle, and modify autogen accordingly. See the comments inside the code for more info

  antocuni

  committed
  616d2c2

  Copy full SHA for 616d2c2

• start to write and to test the logic to create debug handles

  antocuni

  committed
  34bb3d0

  Copy full SHA for 34bb3d0

Commits on Jan 11, 2021

• initialize debug_ctx->h_None & co.: test_noop passes again

  antocuni

  committed
  cc439cf

  Copy full SHA for cc439cf

• add a helper script to invoke pytest inside gdb

  antocuni

  committed
  95770ee

  Copy full SHA for 95770ee

• fix indentation

  antocuni

  committed
  dca923a

  Copy full SHA for dca923a

Commits on Jan 12, 2021

• Merge branch 'antocuni/debugging-tips' into antocuni/debug-mode

  antocuni

  committed
  a0a2302

  Copy full SHA for a0a2302

• typo

  antocuni

  committed
  f58cda4

  Copy full SHA for f58cda4

• make autogen after merging master

  antocuni

  committed
  f7270fc

  Copy full SHA for f7270fc

• Big refactoring in hpy.universal handles

  Show description for d0f7fb7
  antocuni

  committed
  d0f7fb7

  Copy full SHA for d0f7fb7

Commits on Jan 15, 2021

• use +1/-1 instead of ~ for _py2h and _h2py: it's easier to look at them in gdb

  antocuni

  committed
  59184b2

  Copy full SHA for 59184b2

• Fix this XXX: and properly close the handle

  Show description for 484e28d
  antocuni

  committed
  484e28d

  Copy full SHA for 484e28d

• add a helper function to help gdb sessions

  antocuni

  committed
  92216b1

  Copy full SHA for 92216b1

• WIP: refactor everything again.

  Show description for 51bb8de
  antocuni

  committed
  51bb8de

  Copy full SHA for 51bb8de

• rename original_ctx into uctx

  antocuni

  committed
  12b6311

  Copy full SHA for 12b6311

• Start to write the debug mode version of ctx_CallRealFunctionFromTrampoline

  Show description for eadef67
  antocuni

  committed
  eadef67

  Copy full SHA for eadef67

• implement HPyFunc_O

  antocuni

  committed
  d1818ff

  Copy full SHA for d1818ff

• initialize the debug context at runtime instead of compile time. This will make it easier to create thrown-away contexts for tests

  antocuni

  committed
  d770971

  Copy full SHA for d770971

Commits on Jan 17, 2021

• implement the logic for HPy_Close, and add a python function to get the list of all open handles

  antocuni

  committed
  6a481ea

  Copy full SHA for 6a481ea

• Associate a generation to each open handle, and make it possible to get the

  Show description for 2213191
  antocuni

  committed
  2213191

  Copy full SHA for 2213191

• NULL DHPys need a bit of special casing. This is enough to make test_00_basic:test_exception passing again

  antocuni

  committed
  53b78ba

  Copy full SHA for 53b78ba

• implement the HPyFunc_VARARGS case inside debug_ctx_CallRealFunctionFromTrampoline

  antocuni

  committed
  1a44f3d

  Copy full SHA for 1a44f3d

• implement HPyFunc_KEYWORDS

  antocuni

  committed
  f731b95

  Copy full SHA for f731b95

• special case HPy_NULL also inside DHPy_wrap: this is needed to correctly propagate exceptions when wrapped functions return HPy_NULL

  antocuni

  committed
  00db14d

  Copy full SHA for 00db14d

• add a note

  antocuni

  committed
  3799046

  Copy full SHA for 3799046

• add some sanity check to ensure that we don't mix UHPy and DHPy wrongly

  antocuni

  committed
  651aaaf

  Copy full SHA for 651aaaf

• Use dctx and uctx everywhere, to make it clearer what is the ctx we expect in

  Show description for 2e50a13
  antocuni

  committed
  2e50a13

  Copy full SHA for 2e50a13

Commits on Jan 25, 2021

• implement HPyFunct_INITPROC for the debug mode

  antocuni

  committed
  f94104c

  Copy full SHA for f94104c

• implement debug_ctx_Tuple_FromArray

  antocuni

  committed
  24e7588

  Copy full SHA for 24e7588

• implement debug_ctx_Type_GenericNew

  antocuni

  committed
  a186e66

  Copy full SHA for a186e66

• autogen the rest of debug_ctx_CallRealFunctionFromTrampoline; test_slots.py fully passes

  antocuni

  committed
  a670b73

  Copy full SHA for a670b73

• implement debug_ctx_Type_FromSpec manually, since the autogenerated wrapper is not enough

  antocuni

  committed
  0a660c3

  Copy full SHA for 0a660c3

• add a note

  antocuni

  committed
  11974b8

  Copy full SHA for 11974b8

• introduce the applevel view of DebugHandle, and use it in _debug.get_open_handles()

  antocuni

  committed
  5b8d102

  Copy full SHA for 5b8d102

Commits on Jan 26, 2021

• check the result of these two mallocs

  antocuni

  committed
  abe4cc4

  Copy full SHA for abe4cc4

Commits on Jan 27, 2021

• use HPyErr_NoMemory and check whether get_context() fails

  antocuni

  committed
  b1df2ae

  Copy full SHA for b1df2ae

• Tell infer to ignore this file, as it reports a spurious memory leak.

  Show description for cd8cd6e
  antocuni

  committed
  cd8cd6e

  Copy full SHA for cd8cd6e

• introduce DebugHandle.id

  antocuni

  committed
  77fdaf8

  Copy full SHA for 77fdaf8

• Merge branch 'master' into antocuni/debug-mode

  antocuni

  committed
  f5d415d

  Copy full SHA for f5d415d

• fix autogen after the merge

  antocuni

  committed
  64f2e36

  Copy full SHA for 64f2e36

Commits on Jan 28, 2021

• Merge branch 'antocuni/hpy_type' into antocuni/debug-mode

  antocuni

  committed
  4f1f406

  Copy full SHA for 4f1f406

• explain what is a DebugHandleObject

  antocuni

  committed
  239885a

  Copy full SHA for 239885a

• make autogen after the merge of the branch

  antocuni

  committed
  c336f02

  Copy full SHA for c336f02

• add ctx->h_NotImplemented and ctx->h_Ellipsis

  antocuni

  committed
  cb13b9e

  Copy full SHA for cb13b9e

• implement comparisons between DebugHandleObjects

  antocuni

  committed
  c6174be

  Copy full SHA for c6174be

• Merge remote-tracking branch 'origin/master' into antocuni/debug-mode

  antocuni

  committed
  ae25d49

  Copy full SHA for ae25d49

Commits on Jan 29, 2021

• implement DebugHandle.repr

  antocuni

  committed
  bbd00ac

  Copy full SHA for bbd00ac

• implement a simple LeakDetector on top of the low-level debug-mode primitives

  antocuni

  committed
  ebf7c77

  Copy full SHA for ebf7c77

• make it possible to use LeakDetector as a context manager

  antocuni

  committed
  d18c016

  Copy full SHA for d18c016

• avoid the ... syntax, because this file needs to be importable also by py27 (because of pypy applevel tests)

  antocuni

  committed
  beb2d07

  Copy full SHA for beb2d07