Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding HPWHVoltage, MixingValveOutletTemperature #433

Closed
wants to merge 2 commits into from
Closed

adding HPWHVoltage, MixingValveOutletTemperature #433

wants to merge 2 commits into from

Conversation

nmerket
Copy link
Contributor

@nmerket nmerket commented Dec 11, 2024 •
edited
Loading

Fixes #404

Adds two elements to WaterHeatingSystem:

  • HPWHVoltage, with enumerations
    • 240V
    • 120V
    • 120V dedicated circuit
    • 120V shared circuit
  • MixingValveOutletTemperature

@nmerket
Copy link
Contributor Author

nmerket commented Dec 11, 2024

Didn't realize this had already been done in #431

@nmerket nmerket closed this Dec 11, 2024
@nmerket nmerket deleted the hpwh_addl_fields branch December 11, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HPWH additional fields
1 participant
@nmerket