Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemIdentifier attributes #399

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

SystemIdentifier attributes #399

wants to merge 10 commits into from

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jan 19, 2024

Replaces the sameas attribute with retrofit_id to better clarify how the attribute is intended to be used. The attribute description is: "Use to reference the id of the matching object on the base (pre-retrofit) building where the object has not been replaced."

Adds a new shared_id attribute with the description: "Use to reference the id of the same object on another multifamily unit (e.g., a single shared boiler or common wall described in multiple multifamily units)."

@shorowit
Copy link
Contributor Author

shorowit commented Mar 14, 2024

Some software may be using sameas even for situations where the element (e.g., HVAC system) is replaced, or for an AC/furnace->HP situation. Concerns about the "where the object has not been replaced" part of the description; should that be stricken?

Alternatives to pre_retrofit_id... base_id or upgraded_id?

Needs further discussion.

@nmerket
Copy link
Contributor

nmerket commented Mar 20, 2024

@shorowit
Copy link
Contributor Author

shorowit commented Jan 9, 2025

Some software may be using sameas even for situations where the element (e.g., HVAC system) is replaced, or for an AC/furnace->HP situation. Concerns about the "where the object has not been replaced" part of the description; should that be stricken?

It seems like this attribute has been misunderstood/misused. Indeed, I thought the sameas attribute was supposed to be used for, e.g., a wall that has been upgraded during a retrofit, but it turns out that's not the case. It's meant to describe components that do not change during a retrofit. When something changes (either a wall upgrade or an HVAC replacement), a measure is supposed to be defined that links the before and after components. See these sections of the HPXML Implementation Guide:

(It's also not possible to use sameas to describe an AC/furnace->HP replacement since the HP can only refer to one pre-retrofit component.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants