Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on Count #346

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Standardize on Count #346

merged 3 commits into from
Dec 6, 2022

Conversation

shorowit
Copy link
Contributor

Closes #236.

Renames NumberofUnits to Count:

  • Appliances
  • ElectricVehicleCharger
  • LightingGroup

Renames Quantity to Count:

  • Door
  • Window
  • VentilationFan
  • WaterFixture
  • CeilingFan

@shorowit shorowit added this to the v4.0 milestone Sep 21, 2022
@shorowit shorowit self-assigned this Sep 21, 2022
@shorowit shorowit added the merge label Nov 8, 2022
@nmerket
Copy link
Contributor

nmerket commented Nov 9, 2022

🎥 Discussion in HPXML Working Group Meeting 2022-11-08

@shorowit shorowit mentioned this pull request Nov 10, 2022
Merged
4 tasks
@nmerket nmerket merged commit 5b37c69 into master Dec 6, 2022
@nmerket nmerket deleted the count branch December 6, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
breaking change merge schemas
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Standardize Quantity vs NumberofUnits vs Count
2 participants
@shorowit @nmerket