Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support commercial water heaters #334

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Support commercial water heaters #334

merged 5 commits into from
Sep 13, 2022

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Aug 5, 2022

Closes #333.

Conventional storage and instantaneous commercial water heaters

  • Replaces StandbyLoss with StandbyLoss[Units]/Value to support different units (F/hr, %/hr, or Btu/hr). This is a breaking change.
  • Already has a ThermalEfficiency element.

Heat pump commercial water heaters

  • Adds a HeatPumpCOP element.

@shorowit shorowit added this to the v4.0 milestone Aug 5, 2022
@shorowit shorowit self-assigned this Aug 5, 2022
@shorowit shorowit changed the title Allows different units for WaterHeatingSystem/StandbyLoss Support commercial water heaters Aug 5, 2022
@shorowit
Copy link
Contributor Author

shorowit commented Aug 9, 2022

Multiple votes for using fraction instead of percent.

Consider a max limit (e.g., 0.1?). Edit: It's not possible to include a max limit in the XSD because it would not work for other units (F/hr or Btu/hr).

Otherwise HPXML WG was okay with these changes.

@shorowit shorowit added the merge label Aug 9, 2022
@nmerket
Copy link
Contributor

nmerket commented Aug 11, 2022

@shorowit shorowit removed the question label Sep 13, 2022
@nmerket nmerket merged commit 73b09d2 into master Sep 13, 2022
@nmerket nmerket deleted the standby_loss_units branch September 13, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support commercial water heaters
2 participants