DSE values as fractions #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmerket Not sure if this is considered a breaking change, but it seems important to prevent big inconsistencies between software tools that may be interpreting the values in different ways. Software that was using 0-100 would have to change, while software using 0-1 would not. |
|
This is technically a breaking change as it restricts values that used to be valid. It, however, forces consistency in the way the value is described. I think it's worth bending the rule here to remove the possibility of errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces
AnnualHeatingDistributionSystemEfficiencyandAnnualCoolingDistributionSystemEfficiencyvalues to be fractions (0-1). The schema currently allows any number to be provided, so a software tool could be using percentages (0-100). Updated documentation.